Fixing the issue introduced in #3845 for rubi analytics adapter #3996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added the test before the fix and verified that it fails:
And now it passes after the change. |
idettman
reviewed
Jul 15, 2019
idettman
suggested changes
Jul 15, 2019
|
@idettman Thanks, updated both our test adapters to use utils.deepClone |
SublimeLeo
pushed a commit
to SublimeSkinz/Prebid.js
that referenced
this pull request
Jul 16, 2019
…prebid#3996) * Fixing the issue introduced in prebid#3845 for rubi analytics adapter * using utils.deepClone instead of custom clone
leonardlabat
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
Jul 30, 2019
…prebid#3996) * Fixing the issue introduced in prebid#3845 for rubi analytics adapter * using utils.deepClone instead of custom clone
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
…prebid#3996) * Fixing the issue introduced in prebid#3845 for rubi analytics adapter * using utils.deepClone instead of custom clone
sa1omon
pushed a commit
to gamoshi/Prebid.js
that referenced
this pull request
Nov 28, 2019
…prebid#3996) * Fixing the issue introduced in prebid#3845 for rubi analytics adapter * using utils.deepClone instead of custom clone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
The pr introduced here https://github.com/prebid/Prebid.js/pull/3845/files brought out an issue in the rubi analytics adapter.
Since we were not calling the function with the bid obj attached, it was resulting in
this.cpmto throw an exception sincethiswould not be defined with how we are calling it.This PR fixes this issue and adds a unit test to prevent this from happening again