Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c1x adapter - Update all end points to https #4297

Closed
sumit116 opened this issue Oct 14, 2019 · 3 comments
Closed

c1x adapter - Update all end points to https #4297

sumit116 opened this issue Oct 14, 2019 · 3 comments

Comments

@sumit116
Copy link
Contributor

sumit116 commented Oct 14, 2019

Type of issue

Improvement

Description

While doing an internal review for point 2 of the adapter’s section of http://prebid.org/blog/pbjs-3, I observed something unusual in your adapter. I saw you have registered for userSync with pixelUrl in buildRequest(). Can you clarify on why we need to have this change here or submit a PR with the updates yourself?

Following changes need to be addressed:

  1. pixelUrl should only be used with https protocol as a part of work for Prebid3.0 relase. Any conditional statements using http shall be removed.
  2. userSync.registerSync() should not be called in buildRequest(). A separate function getUserSyncs() shall be created and the userSync end point is returned from it.

Platform details

Prebid 3.0

Other information

http://prebid.org/blog/pbjs-3

@sumit116
Copy link
Contributor Author

Hi @CathyHuangtw, can you check this issue?

@CathyHuangtw
Copy link
Contributor

Hi @sumit116
Thank you for letting me know the changes required for Prebid 3.0
I'll take a look and get back to you soon.

@stale
Copy link

stale bot commented Oct 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 29, 2019
@stale stale bot closed this as completed Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants