You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While doing an internal review for point 2 of the adapter’s section of http://prebid.org/blog/pbjs-3, I observed something unusual in your adapter. I saw you have registered for userSync with pixelUrl in buildRequest(). Can you clarify on why we need to have this change here or submit a PR with the updates yourself?
Following changes need to be addressed:
pixelUrl should only be used with https protocol as a part of work for Prebid3.0 relase. Any conditional statements using http shall be removed.
userSync.registerSync() should not be called in buildRequest(). A separate function getUserSyncs() shall be created and the userSync end point is returned from it.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Type of issue
Improvement
Description
While doing an internal review for point 2 of the adapter’s section of http://prebid.org/blog/pbjs-3, I observed something unusual in your adapter. I saw you have registered for userSync with
pixelUrl
in buildRequest(). Can you clarify on why we need to have this change here or submit a PR with the updates yourself?Following changes need to be addressed:
https
protocol as a part of work for Prebid3.0 relase. Any conditional statements usinghttp
shall be removed.Platform details
Prebid 3.0
Other information
http://prebid.org/blog/pbjs-3
The text was updated successfully, but these errors were encountered: