Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all adapters https #4294

Merged
merged 9 commits into from
Nov 26, 2019
Merged

Make all adapters https #4294

merged 9 commits into from
Nov 26, 2019

Conversation

sumit116
Copy link
Contributor

@sumit116 sumit116 commented Oct 14, 2019

Type of change

  • Refactoring

Description of change

Update all adapters' endpoints or any third party urls used by adapter to https protocol.

Other information

We didn't include those adapters in this PR that had conflict with #4249 and would update them after they are submitted from the respective authors.

For some adapters which have multiple end points like test, staging, prod, etc, we have created github issues to clarify things or make changes on their own. Here is the list of those issues:

  1. zedo adapter - Update all end points to https #4310
  2. outcon adapter - Update all end points to https #4309
  3. quantcast adapter - Update all end points to https #4308
  4. freewheel-ssp adapter - Update all end points to https #4307
  5. c1x adapter - Update all end points to https #4297

@sumit116 sumit116 changed the base branch from master to prebid-3.0 October 14, 2019 10:43
@sumit116 sumit116 requested review from jsnellbaker and removed request for jsnellbaker October 14, 2019 13:14
@@ -36,7 +36,7 @@ const SOURCE = 'pbjs';
const MAX_IMPS_PER_REQUEST = 15;
const mappingFileUrl = '//acdn.adnxs.com/prebid/appnexus-mapping/mappings.json';
const SCRIPT_TAG_START = '<script';
const VIEWABILITY_URL_START = /http:\/\/cdn\.adnxs\.com\/v/;
const VIEWABILITY_URL_START = /https:\/\/cdn\.adnxs\.com\/v/;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not need to be changed, we actually need the regex to not include the protocol. We need to change the protocol for this script later in the adapter code so that when it's written to the page, it'll use https.

When the bid returns from the adserver, the default viewability script will be using a protocol that's read from the page. So it would come in as either http or https. Because of this variability, the regex needs to be non-specific.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excluded the protocol from regex.

Sumit Sharma1 added 4 commits October 18, 2019 20:12
… make_all_adapters_https

# Conflicts:
#	modules/appnexusBidAdapter.js
#	test/spec/modules/vidazooBidAdapter_spec.js
@jaiminpanchal27
Copy link
Collaborator

@sumit116 Can you resolve conflicts. Also lets sync up offline and merge this before other merge conflicts appear.

… make_all_adapters_https

# Conflicts:
#	modules/ixBidAdapter.js
#	modules/rubiconBidAdapter.js
#	test/spec/modules/outconBidAdapter_spec.js
@sumit116
Copy link
Contributor Author

@sumit116 Can you resolve conflicts. Also lets sync up offline and merge this before other merge conflicts appear.

@jaiminpanchal27 , conflicts resolved.

@patmmccann
Copy link
Collaborator

districtmdmx still has obj.secure = window.location.protocol === 'https:' ? 1 : 0; so it may return nonsecure inventory even when called on a secure endpoint.

@jaiminpanchal27
Copy link
Collaborator

@patmmccann Fair point but with this PR we are only updating the endpoints. We try not to touch other's adapter implementation unless asked to do so or if it breaks our build.

@sumit116 to create an issue on github and tag them to make updates.

@sumit116
Copy link
Contributor Author

@jaiminpanchal27 , @patmmccann, created github issue #4398

@sumit116
Copy link
Contributor Author

sumit116 commented Nov 8, 2019

HI @msm0504 , can you review these changes and let me know your feedback so that we can merge it to 3.0 branch?

@patmmccann
Copy link
Collaborator

just want to point out that https://github.com/prebid/Prebid.js/pull/4406/files made my comment above irrelevant to that particular adapter

… make_all_adapters_https

# Conflicts:
#	modules/gridBidAdapter.js
#	test/spec/modules/ixBidAdapter_spec.js
@sumit116 sumit116 merged commit 3164cfa into prebid-3.0 Nov 26, 2019
@jsnellbaker jsnellbaker mentioned this pull request Dec 11, 2019
1 task
jsnellbaker added a commit that referenced this pull request Dec 11, 2019
* Remove pbs depracated legacy url (#4226)

* remove deprecated legacy url from pbs adapter

* fix eslint errors

* add and update tests for openRtb2 endpoint

* sync with master

* Revert "sync with master"

This reverts commit 8c2b196.

* removed targeting set filter and moved where render status is set to work with safeframe creatives (#4236)

* Depracate adloader loadscript fn (#4228)

* test commit

* add callback support to loadExternalScript()

* pass moduleCode for renderers

* test cases for loadExternalScript()

* store callbacks for cached url

* fully remove adloader()

* call callback() from stub

* remove and update function name

* getHighestCpmBids only returns non-rendered bids (#4247)

* Make all adapters https (#4294)

* update all adapters to https

* convert all adapters to https

* update unit tests

* remove files confilicting with other PR

* Removed pub common and unified id submodules as defaults in user id module (#4445)

* Deprecate user sync (#4241)

* deprecate some properties of userSync object

* change bid adapter to Appnexus

* fix 3 failing test cases

* make all unit test cases pass

* remove debugger

* deprecate support for adUnit.sizes for pubs (#4458)

* deprecate support for adUnit.sizes for pubs

* remove commented code

* Deprecations utils.js (#4249)

* deprecate domain/referer type functions

* delete modules that are using deprecated methods from utils.js

* remove reference to getTopWindowLocation

* sync with prebid-3.0 branch

* remove test suite for getTopWindowLocation

* add back md files of all deleted adapters

* add md files of deleted analytics adapters

* add adapters that are 3.0 compliant

* add back the rubicon skipped test

* remove min field from priceGranularity feature (#4574)
tadam75 pushed a commit to smartadserver/Prebid.js that referenced this pull request Jan 9, 2020
* Remove pbs depracated legacy url (prebid#4226)

* remove deprecated legacy url from pbs adapter

* fix eslint errors

* add and update tests for openRtb2 endpoint

* sync with master

* Revert "sync with master"

This reverts commit 8c2b196.

* removed targeting set filter and moved where render status is set to work with safeframe creatives (prebid#4236)

* Depracate adloader loadscript fn (prebid#4228)

* test commit

* add callback support to loadExternalScript()

* pass moduleCode for renderers

* test cases for loadExternalScript()

* store callbacks for cached url

* fully remove adloader()

* call callback() from stub

* remove and update function name

* getHighestCpmBids only returns non-rendered bids (prebid#4247)

* Make all adapters https (prebid#4294)

* update all adapters to https

* convert all adapters to https

* update unit tests

* remove files confilicting with other PR

* Removed pub common and unified id submodules as defaults in user id module (prebid#4445)

* Deprecate user sync (prebid#4241)

* deprecate some properties of userSync object

* change bid adapter to Appnexus

* fix 3 failing test cases

* make all unit test cases pass

* remove debugger

* deprecate support for adUnit.sizes for pubs (prebid#4458)

* deprecate support for adUnit.sizes for pubs

* remove commented code

* Deprecations utils.js (prebid#4249)

* deprecate domain/referer type functions

* delete modules that are using deprecated methods from utils.js

* remove reference to getTopWindowLocation

* sync with prebid-3.0 branch

* remove test suite for getTopWindowLocation

* add back md files of all deleted adapters

* add md files of deleted analytics adapters

* add adapters that are 3.0 compliant

* add back the rubicon skipped test

* remove min field from priceGranularity feature (prebid#4574)
bretg pushed a commit that referenced this pull request Jan 15, 2020
* outstream changes

* removing global filtet

* reverting page

* message

* adapter change

* remove space

* testcases

* testpage

* spaces for test page

* renderer exist case

* reverting package-lock.json

* adding schain object

* adding tagid

* syntaxx error fix

* video.html

* space trailing

* space

* tagid

* inventoryId and placement

* rewarded video

* added unit test case

* Remove pbs depracated legacy url (#4226)

* remove deprecated legacy url from pbs adapter

* fix eslint errors

* add and update tests for openRtb2 endpoint

* sync with master

* Revert "sync with master"

This reverts commit 8c2b196.

* removed targeting set filter and moved where render status is set to work with safeframe creatives (#4236)

* Depracate adloader loadscript fn (#4228)

* test commit

* add callback support to loadExternalScript()

* pass moduleCode for renderers

* test cases for loadExternalScript()

* store callbacks for cached url

* fully remove adloader()

* call callback() from stub

* remove and update function name

* getHighestCpmBids only returns non-rendered bids (#4247)

* Make all adapters https (#4294)

* update all adapters to https

* convert all adapters to https

* update unit tests

* remove files confilicting with other PR

* Removed pub common and unified id submodules as defaults in user id module (#4445)

* Deprecate user sync (#4241)

* deprecate some properties of userSync object

* change bid adapter to Appnexus

* fix 3 failing test cases

* make all unit test cases pass

* remove debugger

* deprecate support for adUnit.sizes for pubs (#4458)

* deprecate support for adUnit.sizes for pubs

* remove commented code

* ccpa cahnges

* ccpa change

* test page

* test page change

* test page change 2

* change the variable

* Deprecations utils.js (#4249)

* deprecate domain/referer type functions

* delete modules that are using deprecated methods from utils.js

* remove reference to getTopWindowLocation

* sync with prebid-3.0 branch

* remove test suite for getTopWindowLocation

* add back md files of all deleted adapters

* add md files of deleted analytics adapters

* add adapters that are 3.0 compliant

* add back the rubicon skipped test

* remove min field from priceGranularity feature (#4574)

* ccpa support for v3.0

* Update oneVideoBidAdapter_spec.js

* Update oneVideoBidAdapter.js

* sync pixel chnge

* fix

* sync

* fix

* sync

* sync

* adding gdpr

* test cases

Co-authored-by: sumit sharma <sharmasumit116@gmail.com>
Co-authored-by: Neelanjan Sen <14229985+Fawke@users.noreply.github.com>
Co-authored-by: r-schweitzer <50628828+r-schweitzer@users.noreply.github.com>
Co-authored-by: coryhammon1 <coryhammon1@gmail.com>
Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>
bretg pushed a commit that referenced this pull request Jan 16, 2020
* outstream changes

* removing global filtet

* reverting page

* message

* adapter change

* remove space

* testcases

* testpage

* spaces for test page

* renderer exist case

* reverting package-lock.json

* adding schain object

* adding tagid

* syntaxx error fix

* video.html

* space trailing

* space

* tagid

* inventoryId and placement

* rewarded video

* added unit test case

* Remove pbs depracated legacy url (#4226)

* remove deprecated legacy url from pbs adapter

* fix eslint errors

* add and update tests for openRtb2 endpoint

* sync with master

* Revert "sync with master"

This reverts commit 8c2b196.

* removed targeting set filter and moved where render status is set to work with safeframe creatives (#4236)

* Depracate adloader loadscript fn (#4228)

* test commit

* add callback support to loadExternalScript()

* pass moduleCode for renderers

* test cases for loadExternalScript()

* store callbacks for cached url

* fully remove adloader()

* call callback() from stub

* remove and update function name

* getHighestCpmBids only returns non-rendered bids (#4247)

* Make all adapters https (#4294)

* update all adapters to https

* convert all adapters to https

* update unit tests

* remove files confilicting with other PR

* Removed pub common and unified id submodules as defaults in user id module (#4445)

* Deprecate user sync (#4241)

* deprecate some properties of userSync object

* change bid adapter to Appnexus

* fix 3 failing test cases

* make all unit test cases pass

* remove debugger

* deprecate support for adUnit.sizes for pubs (#4458)

* deprecate support for adUnit.sizes for pubs

* remove commented code

* ccpa cahnges

* ccpa change

* test page

* test page change

* test page change 2

* change the variable

* Deprecations utils.js (#4249)

* deprecate domain/referer type functions

* delete modules that are using deprecated methods from utils.js

* remove reference to getTopWindowLocation

* sync with prebid-3.0 branch

* remove test suite for getTopWindowLocation

* add back md files of all deleted adapters

* add md files of deleted analytics adapters

* add adapters that are 3.0 compliant

* add back the rubicon skipped test

* remove min field from priceGranularity feature (#4574)

* ccpa support for v3.0

* Update oneVideoBidAdapter_spec.js

* Update oneVideoBidAdapter.js

* sync pixel chnge

* fix

* sync

* fix

* sync

* sync

* adding gdpr

* test cases

* test cases

* test case

Co-authored-by: sumit sharma <sharmasumit116@gmail.com>
Co-authored-by: Neelanjan Sen <14229985+Fawke@users.noreply.github.com>
Co-authored-by: r-schweitzer <50628828+r-schweitzer@users.noreply.github.com>
Co-authored-by: coryhammon1 <coryhammon1@gmail.com>
Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>
audiencerun pushed a commit to audiencerun/Prebid.js that referenced this pull request Jan 20, 2020
* outstream changes

* removing global filtet

* reverting page

* message

* adapter change

* remove space

* testcases

* testpage

* spaces for test page

* renderer exist case

* reverting package-lock.json

* adding schain object

* adding tagid

* syntaxx error fix

* video.html

* space trailing

* space

* tagid

* inventoryId and placement

* rewarded video

* added unit test case

* Remove pbs depracated legacy url (prebid#4226)

* remove deprecated legacy url from pbs adapter

* fix eslint errors

* add and update tests for openRtb2 endpoint

* sync with master

* Revert "sync with master"

This reverts commit 8c2b196.

* removed targeting set filter and moved where render status is set to work with safeframe creatives (prebid#4236)

* Depracate adloader loadscript fn (prebid#4228)

* test commit

* add callback support to loadExternalScript()

* pass moduleCode for renderers

* test cases for loadExternalScript()

* store callbacks for cached url

* fully remove adloader()

* call callback() from stub

* remove and update function name

* getHighestCpmBids only returns non-rendered bids (prebid#4247)

* Make all adapters https (prebid#4294)

* update all adapters to https

* convert all adapters to https

* update unit tests

* remove files confilicting with other PR

* Removed pub common and unified id submodules as defaults in user id module (prebid#4445)

* Deprecate user sync (prebid#4241)

* deprecate some properties of userSync object

* change bid adapter to Appnexus

* fix 3 failing test cases

* make all unit test cases pass

* remove debugger

* deprecate support for adUnit.sizes for pubs (prebid#4458)

* deprecate support for adUnit.sizes for pubs

* remove commented code

* ccpa cahnges

* ccpa change

* test page

* test page change

* test page change 2

* change the variable

* Deprecations utils.js (prebid#4249)

* deprecate domain/referer type functions

* delete modules that are using deprecated methods from utils.js

* remove reference to getTopWindowLocation

* sync with prebid-3.0 branch

* remove test suite for getTopWindowLocation

* add back md files of all deleted adapters

* add md files of deleted analytics adapters

* add adapters that are 3.0 compliant

* add back the rubicon skipped test

* remove min field from priceGranularity feature (prebid#4574)

* ccpa support for v3.0

* Update oneVideoBidAdapter_spec.js

* Update oneVideoBidAdapter.js

* sync pixel chnge

* fix

* sync

* fix

* sync

* sync

* adding gdpr

* test cases

Co-authored-by: sumit sharma <sharmasumit116@gmail.com>
Co-authored-by: Neelanjan Sen <14229985+Fawke@users.noreply.github.com>
Co-authored-by: r-schweitzer <50628828+r-schweitzer@users.noreply.github.com>
Co-authored-by: coryhammon1 <coryhammon1@gmail.com>
Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>
audiencerun pushed a commit to audiencerun/Prebid.js that referenced this pull request Jan 20, 2020
* outstream changes

* removing global filtet

* reverting page

* message

* adapter change

* remove space

* testcases

* testpage

* spaces for test page

* renderer exist case

* reverting package-lock.json

* adding schain object

* adding tagid

* syntaxx error fix

* video.html

* space trailing

* space

* tagid

* inventoryId and placement

* rewarded video

* added unit test case

* Remove pbs depracated legacy url (prebid#4226)

* remove deprecated legacy url from pbs adapter

* fix eslint errors

* add and update tests for openRtb2 endpoint

* sync with master

* Revert "sync with master"

This reverts commit 8c2b196.

* removed targeting set filter and moved where render status is set to work with safeframe creatives (prebid#4236)

* Depracate adloader loadscript fn (prebid#4228)

* test commit

* add callback support to loadExternalScript()

* pass moduleCode for renderers

* test cases for loadExternalScript()

* store callbacks for cached url

* fully remove adloader()

* call callback() from stub

* remove and update function name

* getHighestCpmBids only returns non-rendered bids (prebid#4247)

* Make all adapters https (prebid#4294)

* update all adapters to https

* convert all adapters to https

* update unit tests

* remove files confilicting with other PR

* Removed pub common and unified id submodules as defaults in user id module (prebid#4445)

* Deprecate user sync (prebid#4241)

* deprecate some properties of userSync object

* change bid adapter to Appnexus

* fix 3 failing test cases

* make all unit test cases pass

* remove debugger

* deprecate support for adUnit.sizes for pubs (prebid#4458)

* deprecate support for adUnit.sizes for pubs

* remove commented code

* ccpa cahnges

* ccpa change

* test page

* test page change

* test page change 2

* change the variable

* Deprecations utils.js (prebid#4249)

* deprecate domain/referer type functions

* delete modules that are using deprecated methods from utils.js

* remove reference to getTopWindowLocation

* sync with prebid-3.0 branch

* remove test suite for getTopWindowLocation

* add back md files of all deleted adapters

* add md files of deleted analytics adapters

* add adapters that are 3.0 compliant

* add back the rubicon skipped test

* remove min field from priceGranularity feature (prebid#4574)

* ccpa support for v3.0

* Update oneVideoBidAdapter_spec.js

* Update oneVideoBidAdapter.js

* sync pixel chnge

* fix

* sync

* fix

* sync

* sync

* adding gdpr

* test cases

* test cases

* test case

Co-authored-by: sumit sharma <sharmasumit116@gmail.com>
Co-authored-by: Neelanjan Sen <14229985+Fawke@users.noreply.github.com>
Co-authored-by: r-schweitzer <50628828+r-schweitzer@users.noreply.github.com>
Co-authored-by: coryhammon1 <coryhammon1@gmail.com>
Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>
hellsingblack pushed a commit to SublimeSkinz/Prebid.js that referenced this pull request Mar 5, 2020
* outstream changes

* removing global filtet

* reverting page

* message

* adapter change

* remove space

* testcases

* testpage

* spaces for test page

* renderer exist case

* reverting package-lock.json

* adding schain object

* adding tagid

* syntaxx error fix

* video.html

* space trailing

* space

* tagid

* inventoryId and placement

* rewarded video

* added unit test case

* Remove pbs depracated legacy url (prebid#4226)

* remove deprecated legacy url from pbs adapter

* fix eslint errors

* add and update tests for openRtb2 endpoint

* sync with master

* Revert "sync with master"

This reverts commit 8c2b196.

* removed targeting set filter and moved where render status is set to work with safeframe creatives (prebid#4236)

* Depracate adloader loadscript fn (prebid#4228)

* test commit

* add callback support to loadExternalScript()

* pass moduleCode for renderers

* test cases for loadExternalScript()

* store callbacks for cached url

* fully remove adloader()

* call callback() from stub

* remove and update function name

* getHighestCpmBids only returns non-rendered bids (prebid#4247)

* Make all adapters https (prebid#4294)

* update all adapters to https

* convert all adapters to https

* update unit tests

* remove files confilicting with other PR

* Removed pub common and unified id submodules as defaults in user id module (prebid#4445)

* Deprecate user sync (prebid#4241)

* deprecate some properties of userSync object

* change bid adapter to Appnexus

* fix 3 failing test cases

* make all unit test cases pass

* remove debugger

* deprecate support for adUnit.sizes for pubs (prebid#4458)

* deprecate support for adUnit.sizes for pubs

* remove commented code

* ccpa cahnges

* ccpa change

* test page

* test page change

* test page change 2

* change the variable

* Deprecations utils.js (prebid#4249)

* deprecate domain/referer type functions

* delete modules that are using deprecated methods from utils.js

* remove reference to getTopWindowLocation

* sync with prebid-3.0 branch

* remove test suite for getTopWindowLocation

* add back md files of all deleted adapters

* add md files of deleted analytics adapters

* add adapters that are 3.0 compliant

* add back the rubicon skipped test

* remove min field from priceGranularity feature (prebid#4574)

* ccpa support for v3.0

* Update oneVideoBidAdapter_spec.js

* Update oneVideoBidAdapter.js

* sync pixel chnge

* fix

* sync

* fix

* sync

* sync

* adding gdpr

* test cases

Co-authored-by: sumit sharma <sharmasumit116@gmail.com>
Co-authored-by: Neelanjan Sen <14229985+Fawke@users.noreply.github.com>
Co-authored-by: r-schweitzer <50628828+r-schweitzer@users.noreply.github.com>
Co-authored-by: coryhammon1 <coryhammon1@gmail.com>
Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>
hellsingblack pushed a commit to SublimeSkinz/Prebid.js that referenced this pull request Mar 5, 2020
* outstream changes

* removing global filtet

* reverting page

* message

* adapter change

* remove space

* testcases

* testpage

* spaces for test page

* renderer exist case

* reverting package-lock.json

* adding schain object

* adding tagid

* syntaxx error fix

* video.html

* space trailing

* space

* tagid

* inventoryId and placement

* rewarded video

* added unit test case

* Remove pbs depracated legacy url (prebid#4226)

* remove deprecated legacy url from pbs adapter

* fix eslint errors

* add and update tests for openRtb2 endpoint

* sync with master

* Revert "sync with master"

This reverts commit 8c2b196.

* removed targeting set filter and moved where render status is set to work with safeframe creatives (prebid#4236)

* Depracate adloader loadscript fn (prebid#4228)

* test commit

* add callback support to loadExternalScript()

* pass moduleCode for renderers

* test cases for loadExternalScript()

* store callbacks for cached url

* fully remove adloader()

* call callback() from stub

* remove and update function name

* getHighestCpmBids only returns non-rendered bids (prebid#4247)

* Make all adapters https (prebid#4294)

* update all adapters to https

* convert all adapters to https

* update unit tests

* remove files confilicting with other PR

* Removed pub common and unified id submodules as defaults in user id module (prebid#4445)

* Deprecate user sync (prebid#4241)

* deprecate some properties of userSync object

* change bid adapter to Appnexus

* fix 3 failing test cases

* make all unit test cases pass

* remove debugger

* deprecate support for adUnit.sizes for pubs (prebid#4458)

* deprecate support for adUnit.sizes for pubs

* remove commented code

* ccpa cahnges

* ccpa change

* test page

* test page change

* test page change 2

* change the variable

* Deprecations utils.js (prebid#4249)

* deprecate domain/referer type functions

* delete modules that are using deprecated methods from utils.js

* remove reference to getTopWindowLocation

* sync with prebid-3.0 branch

* remove test suite for getTopWindowLocation

* add back md files of all deleted adapters

* add md files of deleted analytics adapters

* add adapters that are 3.0 compliant

* add back the rubicon skipped test

* remove min field from priceGranularity feature (prebid#4574)

* ccpa support for v3.0

* Update oneVideoBidAdapter_spec.js

* Update oneVideoBidAdapter.js

* sync pixel chnge

* fix

* sync

* fix

* sync

* sync

* adding gdpr

* test cases

* test cases

* test case

Co-authored-by: sumit sharma <sharmasumit116@gmail.com>
Co-authored-by: Neelanjan Sen <14229985+Fawke@users.noreply.github.com>
Co-authored-by: r-schweitzer <50628828+r-schweitzer@users.noreply.github.com>
Co-authored-by: coryhammon1 <coryhammon1@gmail.com>
Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants