Deprecations utils.js #4249

Fawke · 2019-10-01T11:37:41Z

Type of change

Other

Description of change

Deprecated functions in src/utils.js

getTopWindowLocation()
getTopFrameReferrer()
getAncestorOrigins()
getTopWindowUrl()
getTopWindowReferrer()

Test cases have been updated to reflect the change.

Adapters which were using this deprecated functions have been removed.

Please review but don't merge this time.

mkendall07 · 2019-10-01T13:32:12Z

This pull request fixes 5 alerts when merging 3b5f3fa into 8855c1e - view on LGTM.com

fixed alerts:

3 for Useless conditional
1 for Useless assignment to local variable
1 for Superfluous trailing arguments

Warning - Automated code review for prebid/Prebid.js will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

idettman · 2019-10-03T18:11:48Z

Is the changed files count 314 correct?

…bid.js into deprecations-utils.js

idettman

LGTM considering the following:
This PR removes the deprecated functions and also the adapters, which were using the functions. There were more than 100 such adapters and we removed their .js files and spec to make the unit test and the build pass.

anand-venkatraman · 2019-10-15T14:15:39Z

PulsePoint adapter updated to remove usage of deprecated function #4257

lgtm-com · 2019-11-11T10:53:02Z

This pull request fixes 8 alerts when merging 8f1d27f into 46e635b - view on LGTM.com

fixed alerts:

3 for Useless conditional
3 for Use of returnless function
1 for Superfluous trailing arguments
1 for Client-side cross-site scripting

lgtm-com · 2019-12-02T14:23:06Z

This pull request fixes 5 alerts when merging 4f6c88a into 549f273 - view on LGTM.com

fixed alerts:

3 for Useless conditional
1 for Superfluous trailing arguments
1 for Client-side cross-site scripting

idettman · 2019-12-04T18:57:47Z

@Fawke can you update and resolve the conflicts

lgtm-com · 2019-12-05T09:53:08Z

This pull request fixes 5 alerts when merging 34b7d72 into dc586d1 - view on LGTM.com

fixed alerts:

3 for Useless conditional
1 for Superfluous trailing arguments
1 for Client-side cross-site scripting

Fawke · 2019-12-06T06:25:26Z

@Fawke can you update and resolve the conflicts

Resolved!

Fawke · 2019-12-09T10:23:42Z

@idettman Would you be able to help me resolve an issue with RubiconBidAdapter_spec.js file? After my last sync with the prebid-3.0 branch, one of the test cases in that file is failing, precisely this test.

Prebid.js/test/spec/modules/rubiconBidAdapter_spec.js

Line 474 in 34b7d72

it.skip('ad engine query params should be ordered correctly', function () {

I tried fix the test, but I wasn't able to. So, right now, I've skipped this test to make the build successful. Would you be able to help me figure out what's wrong with the test, or how to make it pass?

lgtm-com · 2019-12-10T07:53:10Z

This pull request fixes 5 alerts when merging 7424c5b into a7034d1 - view on LGTM.com

fixed alerts:

3 for Useless conditional
1 for Superfluous trailing arguments
1 for Client-side cross-site scripting

jaiminpanchal27

LGTM. Just one comment

jaiminpanchal27 · 2019-12-10T19:33:01Z

test/spec/modules/rubiconBidAdapter_spec.js

@@ -476,7 +476,7 @@ describe('the rubicon adapter', function () {
          expect(request.data).to.not.contain('x_source.pchain');
        });

-        it('ad engine query params should be ordered correctly', function () {
+        it.skip('ad engine query params should be ordered correctly', function () {


Any reason to skip this test ?

@jaiminpanchal27 Previously, this test case was failing due to some unknown reason, but, we verified it again and it seems to be passing. Have added this test back in my latest commit.

Fawke · 2019-12-11T07:59:32Z

@idettman Would you be able to help me resolve an issue with RubiconBidAdapter_spec.js file? After my last sync with the prebid-3.0 branch, one of the test cases in that file is failing, precisely this test.

Prebid.js/test/spec/modules/rubiconBidAdapter_spec.js

Line 474 in 34b7d72

it.skip('ad engine query params should be ordered correctly', function () {

I tried fix the test, but I wasn't able to. So, right now, I've skipped this test to make the build successful. Would you be able to help me figure out what's wrong with the test, or how to make it pass?

@idettman Nevermind, the test seems to be passing now.

lgtm-com · 2019-12-11T08:03:16Z

This pull request fixes 5 alerts when merging 2c66fd8 into a7034d1 - view on LGTM.com

fixed alerts:

3 for Useless conditional
1 for Superfluous trailing arguments
1 for Client-side cross-site scripting

lgtm-com · 2019-12-11T13:38:43Z

This pull request fixes 5 alerts when merging c2386fb into ca23f38 - view on LGTM.com

fixed alerts:

3 for Useless conditional
1 for Superfluous trailing arguments
1 for Client-side cross-site scripting

* Remove pbs depracated legacy url (#4226) * remove deprecated legacy url from pbs adapter * fix eslint errors * add and update tests for openRtb2 endpoint * sync with master * Revert "sync with master" This reverts commit 8c2b196. * removed targeting set filter and moved where render status is set to work with safeframe creatives (#4236) * Depracate adloader loadscript fn (#4228) * test commit * add callback support to loadExternalScript() * pass moduleCode for renderers * test cases for loadExternalScript() * store callbacks for cached url * fully remove adloader() * call callback() from stub * remove and update function name * getHighestCpmBids only returns non-rendered bids (#4247) * Make all adapters https (#4294) * update all adapters to https * convert all adapters to https * update unit tests * remove files confilicting with other PR * Removed pub common and unified id submodules as defaults in user id module (#4445) * Deprecate user sync (#4241) * deprecate some properties of userSync object * change bid adapter to Appnexus * fix 3 failing test cases * make all unit test cases pass * remove debugger * deprecate support for adUnit.sizes for pubs (#4458) * deprecate support for adUnit.sizes for pubs * remove commented code * Deprecations utils.js (#4249) * deprecate domain/referer type functions * delete modules that are using deprecated methods from utils.js * remove reference to getTopWindowLocation * sync with prebid-3.0 branch * remove test suite for getTopWindowLocation * add back md files of all deleted adapters * add md files of deleted analytics adapters * add adapters that are 3.0 compliant * add back the rubicon skipped test * remove min field from priceGranularity feature (#4574)

* Remove pbs depracated legacy url (prebid#4226) * remove deprecated legacy url from pbs adapter * fix eslint errors * add and update tests for openRtb2 endpoint * sync with master * Revert "sync with master" This reverts commit 8c2b196. * removed targeting set filter and moved where render status is set to work with safeframe creatives (prebid#4236) * Depracate adloader loadscript fn (prebid#4228) * test commit * add callback support to loadExternalScript() * pass moduleCode for renderers * test cases for loadExternalScript() * store callbacks for cached url * fully remove adloader() * call callback() from stub * remove and update function name * getHighestCpmBids only returns non-rendered bids (prebid#4247) * Make all adapters https (prebid#4294) * update all adapters to https * convert all adapters to https * update unit tests * remove files confilicting with other PR * Removed pub common and unified id submodules as defaults in user id module (prebid#4445) * Deprecate user sync (prebid#4241) * deprecate some properties of userSync object * change bid adapter to Appnexus * fix 3 failing test cases * make all unit test cases pass * remove debugger * deprecate support for adUnit.sizes for pubs (prebid#4458) * deprecate support for adUnit.sizes for pubs * remove commented code * Deprecations utils.js (prebid#4249) * deprecate domain/referer type functions * delete modules that are using deprecated methods from utils.js * remove reference to getTopWindowLocation * sync with prebid-3.0 branch * remove test suite for getTopWindowLocation * add back md files of all deleted adapters * add md files of deleted analytics adapters * add adapters that are 3.0 compliant * add back the rubicon skipped test * remove min field from priceGranularity feature (prebid#4574)

* outstream changes * removing global filtet * reverting page * message * adapter change * remove space * testcases * testpage * spaces for test page * renderer exist case * reverting package-lock.json * adding schain object * adding tagid * syntaxx error fix * video.html * space trailing * space * tagid * inventoryId and placement * rewarded video * added unit test case * Remove pbs depracated legacy url (#4226) * remove deprecated legacy url from pbs adapter * fix eslint errors * add and update tests for openRtb2 endpoint * sync with master * Revert "sync with master" This reverts commit 8c2b196. * removed targeting set filter and moved where render status is set to work with safeframe creatives (#4236) * Depracate adloader loadscript fn (#4228) * test commit * add callback support to loadExternalScript() * pass moduleCode for renderers * test cases for loadExternalScript() * store callbacks for cached url * fully remove adloader() * call callback() from stub * remove and update function name * getHighestCpmBids only returns non-rendered bids (#4247) * Make all adapters https (#4294) * update all adapters to https * convert all adapters to https * update unit tests * remove files confilicting with other PR * Removed pub common and unified id submodules as defaults in user id module (#4445) * Deprecate user sync (#4241) * deprecate some properties of userSync object * change bid adapter to Appnexus * fix 3 failing test cases * make all unit test cases pass * remove debugger * deprecate support for adUnit.sizes for pubs (#4458) * deprecate support for adUnit.sizes for pubs * remove commented code * ccpa cahnges * ccpa change * test page * test page change * test page change 2 * change the variable * Deprecations utils.js (#4249) * deprecate domain/referer type functions * delete modules that are using deprecated methods from utils.js * remove reference to getTopWindowLocation * sync with prebid-3.0 branch * remove test suite for getTopWindowLocation * add back md files of all deleted adapters * add md files of deleted analytics adapters * add adapters that are 3.0 compliant * add back the rubicon skipped test * remove min field from priceGranularity feature (#4574) * ccpa support for v3.0 * Update oneVideoBidAdapter_spec.js * Update oneVideoBidAdapter.js * sync pixel chnge * fix * sync * fix * sync * sync * adding gdpr * test cases Co-authored-by: sumit sharma <sharmasumit116@gmail.com> Co-authored-by: Neelanjan Sen <14229985+Fawke@users.noreply.github.com> Co-authored-by: r-schweitzer <50628828+r-schweitzer@users.noreply.github.com> Co-authored-by: coryhammon1 <coryhammon1@gmail.com> Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>

* outstream changes * removing global filtet * reverting page * message * adapter change * remove space * testcases * testpage * spaces for test page * renderer exist case * reverting package-lock.json * adding schain object * adding tagid * syntaxx error fix * video.html * space trailing * space * tagid * inventoryId and placement * rewarded video * added unit test case * Remove pbs depracated legacy url (#4226) * remove deprecated legacy url from pbs adapter * fix eslint errors * add and update tests for openRtb2 endpoint * sync with master * Revert "sync with master" This reverts commit 8c2b196. * removed targeting set filter and moved where render status is set to work with safeframe creatives (#4236) * Depracate adloader loadscript fn (#4228) * test commit * add callback support to loadExternalScript() * pass moduleCode for renderers * test cases for loadExternalScript() * store callbacks for cached url * fully remove adloader() * call callback() from stub * remove and update function name * getHighestCpmBids only returns non-rendered bids (#4247) * Make all adapters https (#4294) * update all adapters to https * convert all adapters to https * update unit tests * remove files confilicting with other PR * Removed pub common and unified id submodules as defaults in user id module (#4445) * Deprecate user sync (#4241) * deprecate some properties of userSync object * change bid adapter to Appnexus * fix 3 failing test cases * make all unit test cases pass * remove debugger * deprecate support for adUnit.sizes for pubs (#4458) * deprecate support for adUnit.sizes for pubs * remove commented code * ccpa cahnges * ccpa change * test page * test page change * test page change 2 * change the variable * Deprecations utils.js (#4249) * deprecate domain/referer type functions * delete modules that are using deprecated methods from utils.js * remove reference to getTopWindowLocation * sync with prebid-3.0 branch * remove test suite for getTopWindowLocation * add back md files of all deleted adapters * add md files of deleted analytics adapters * add adapters that are 3.0 compliant * add back the rubicon skipped test * remove min field from priceGranularity feature (#4574) * ccpa support for v3.0 * Update oneVideoBidAdapter_spec.js * Update oneVideoBidAdapter.js * sync pixel chnge * fix * sync * fix * sync * sync * adding gdpr * test cases * test cases * test case Co-authored-by: sumit sharma <sharmasumit116@gmail.com> Co-authored-by: Neelanjan Sen <14229985+Fawke@users.noreply.github.com> Co-authored-by: r-schweitzer <50628828+r-schweitzer@users.noreply.github.com> Co-authored-by: coryhammon1 <coryhammon1@gmail.com> Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>

* outstream changes * removing global filtet * reverting page * message * adapter change * remove space * testcases * testpage * spaces for test page * renderer exist case * reverting package-lock.json * adding schain object * adding tagid * syntaxx error fix * video.html * space trailing * space * tagid * inventoryId and placement * rewarded video * added unit test case * Remove pbs depracated legacy url (prebid#4226) * remove deprecated legacy url from pbs adapter * fix eslint errors * add and update tests for openRtb2 endpoint * sync with master * Revert "sync with master" This reverts commit 8c2b196. * removed targeting set filter and moved where render status is set to work with safeframe creatives (prebid#4236) * Depracate adloader loadscript fn (prebid#4228) * test commit * add callback support to loadExternalScript() * pass moduleCode for renderers * test cases for loadExternalScript() * store callbacks for cached url * fully remove adloader() * call callback() from stub * remove and update function name * getHighestCpmBids only returns non-rendered bids (prebid#4247) * Make all adapters https (prebid#4294) * update all adapters to https * convert all adapters to https * update unit tests * remove files confilicting with other PR * Removed pub common and unified id submodules as defaults in user id module (prebid#4445) * Deprecate user sync (prebid#4241) * deprecate some properties of userSync object * change bid adapter to Appnexus * fix 3 failing test cases * make all unit test cases pass * remove debugger * deprecate support for adUnit.sizes for pubs (prebid#4458) * deprecate support for adUnit.sizes for pubs * remove commented code * ccpa cahnges * ccpa change * test page * test page change * test page change 2 * change the variable * Deprecations utils.js (prebid#4249) * deprecate domain/referer type functions * delete modules that are using deprecated methods from utils.js * remove reference to getTopWindowLocation * sync with prebid-3.0 branch * remove test suite for getTopWindowLocation * add back md files of all deleted adapters * add md files of deleted analytics adapters * add adapters that are 3.0 compliant * add back the rubicon skipped test * remove min field from priceGranularity feature (prebid#4574) * ccpa support for v3.0 * Update oneVideoBidAdapter_spec.js * Update oneVideoBidAdapter.js * sync pixel chnge * fix * sync * fix * sync * sync * adding gdpr * test cases Co-authored-by: sumit sharma <sharmasumit116@gmail.com> Co-authored-by: Neelanjan Sen <14229985+Fawke@users.noreply.github.com> Co-authored-by: r-schweitzer <50628828+r-schweitzer@users.noreply.github.com> Co-authored-by: coryhammon1 <coryhammon1@gmail.com> Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>

* outstream changes * removing global filtet * reverting page * message * adapter change * remove space * testcases * testpage * spaces for test page * renderer exist case * reverting package-lock.json * adding schain object * adding tagid * syntaxx error fix * video.html * space trailing * space * tagid * inventoryId and placement * rewarded video * added unit test case * Remove pbs depracated legacy url (prebid#4226) * remove deprecated legacy url from pbs adapter * fix eslint errors * add and update tests for openRtb2 endpoint * sync with master * Revert "sync with master" This reverts commit 8c2b196. * removed targeting set filter and moved where render status is set to work with safeframe creatives (prebid#4236) * Depracate adloader loadscript fn (prebid#4228) * test commit * add callback support to loadExternalScript() * pass moduleCode for renderers * test cases for loadExternalScript() * store callbacks for cached url * fully remove adloader() * call callback() from stub * remove and update function name * getHighestCpmBids only returns non-rendered bids (prebid#4247) * Make all adapters https (prebid#4294) * update all adapters to https * convert all adapters to https * update unit tests * remove files confilicting with other PR * Removed pub common and unified id submodules as defaults in user id module (prebid#4445) * Deprecate user sync (prebid#4241) * deprecate some properties of userSync object * change bid adapter to Appnexus * fix 3 failing test cases * make all unit test cases pass * remove debugger * deprecate support for adUnit.sizes for pubs (prebid#4458) * deprecate support for adUnit.sizes for pubs * remove commented code * ccpa cahnges * ccpa change * test page * test page change * test page change 2 * change the variable * Deprecations utils.js (prebid#4249) * deprecate domain/referer type functions * delete modules that are using deprecated methods from utils.js * remove reference to getTopWindowLocation * sync with prebid-3.0 branch * remove test suite for getTopWindowLocation * add back md files of all deleted adapters * add md files of deleted analytics adapters * add adapters that are 3.0 compliant * add back the rubicon skipped test * remove min field from priceGranularity feature (prebid#4574) * ccpa support for v3.0 * Update oneVideoBidAdapter_spec.js * Update oneVideoBidAdapter.js * sync pixel chnge * fix * sync * fix * sync * sync * adding gdpr * test cases * test cases * test case Co-authored-by: sumit sharma <sharmasumit116@gmail.com> Co-authored-by: Neelanjan Sen <14229985+Fawke@users.noreply.github.com> Co-authored-by: r-schweitzer <50628828+r-schweitzer@users.noreply.github.com> Co-authored-by: coryhammon1 <coryhammon1@gmail.com> Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>

* outstream changes * removing global filtet * reverting page * message * adapter change * remove space * testcases * testpage * spaces for test page * renderer exist case * reverting package-lock.json * adding schain object * adding tagid * syntaxx error fix * video.html * space trailing * space * tagid * inventoryId and placement * rewarded video * added unit test case * Remove pbs depracated legacy url (prebid#4226) * remove deprecated legacy url from pbs adapter * fix eslint errors * add and update tests for openRtb2 endpoint * sync with master * Revert "sync with master" This reverts commit 8c2b196. * removed targeting set filter and moved where render status is set to work with safeframe creatives (prebid#4236) * Depracate adloader loadscript fn (prebid#4228) * test commit * add callback support to loadExternalScript() * pass moduleCode for renderers * test cases for loadExternalScript() * store callbacks for cached url * fully remove adloader() * call callback() from stub * remove and update function name * getHighestCpmBids only returns non-rendered bids (prebid#4247) * Make all adapters https (prebid#4294) * update all adapters to https * convert all adapters to https * update unit tests * remove files confilicting with other PR * Removed pub common and unified id submodules as defaults in user id module (prebid#4445) * Deprecate user sync (prebid#4241) * deprecate some properties of userSync object * change bid adapter to Appnexus * fix 3 failing test cases * make all unit test cases pass * remove debugger * deprecate support for adUnit.sizes for pubs (prebid#4458) * deprecate support for adUnit.sizes for pubs * remove commented code * ccpa cahnges * ccpa change * test page * test page change * test page change 2 * change the variable * Deprecations utils.js (prebid#4249) * deprecate domain/referer type functions * delete modules that are using deprecated methods from utils.js * remove reference to getTopWindowLocation * sync with prebid-3.0 branch * remove test suite for getTopWindowLocation * add back md files of all deleted adapters * add md files of deleted analytics adapters * add adapters that are 3.0 compliant * add back the rubicon skipped test * remove min field from priceGranularity feature (prebid#4574) * ccpa support for v3.0 * Update oneVideoBidAdapter_spec.js * Update oneVideoBidAdapter.js * sync pixel chnge * fix * sync * fix * sync * sync * adding gdpr * test cases Co-authored-by: sumit sharma <sharmasumit116@gmail.com> Co-authored-by: Neelanjan Sen <14229985+Fawke@users.noreply.github.com> Co-authored-by: r-schweitzer <50628828+r-schweitzer@users.noreply.github.com> Co-authored-by: coryhammon1 <coryhammon1@gmail.com> Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>

* outstream changes * removing global filtet * reverting page * message * adapter change * remove space * testcases * testpage * spaces for test page * renderer exist case * reverting package-lock.json * adding schain object * adding tagid * syntaxx error fix * video.html * space trailing * space * tagid * inventoryId and placement * rewarded video * added unit test case * Remove pbs depracated legacy url (prebid#4226) * remove deprecated legacy url from pbs adapter * fix eslint errors * add and update tests for openRtb2 endpoint * sync with master * Revert "sync with master" This reverts commit 8c2b196. * removed targeting set filter and moved where render status is set to work with safeframe creatives (prebid#4236) * Depracate adloader loadscript fn (prebid#4228) * test commit * add callback support to loadExternalScript() * pass moduleCode for renderers * test cases for loadExternalScript() * store callbacks for cached url * fully remove adloader() * call callback() from stub * remove and update function name * getHighestCpmBids only returns non-rendered bids (prebid#4247) * Make all adapters https (prebid#4294) * update all adapters to https * convert all adapters to https * update unit tests * remove files confilicting with other PR * Removed pub common and unified id submodules as defaults in user id module (prebid#4445) * Deprecate user sync (prebid#4241) * deprecate some properties of userSync object * change bid adapter to Appnexus * fix 3 failing test cases * make all unit test cases pass * remove debugger * deprecate support for adUnit.sizes for pubs (prebid#4458) * deprecate support for adUnit.sizes for pubs * remove commented code * ccpa cahnges * ccpa change * test page * test page change * test page change 2 * change the variable * Deprecations utils.js (prebid#4249) * deprecate domain/referer type functions * delete modules that are using deprecated methods from utils.js * remove reference to getTopWindowLocation * sync with prebid-3.0 branch * remove test suite for getTopWindowLocation * add back md files of all deleted adapters * add md files of deleted analytics adapters * add adapters that are 3.0 compliant * add back the rubicon skipped test * remove min field from priceGranularity feature (prebid#4574) * ccpa support for v3.0 * Update oneVideoBidAdapter_spec.js * Update oneVideoBidAdapter.js * sync pixel chnge * fix * sync * fix * sync * sync * adding gdpr * test cases * test cases * test case Co-authored-by: sumit sharma <sharmasumit116@gmail.com> Co-authored-by: Neelanjan Sen <14229985+Fawke@users.noreply.github.com> Co-authored-by: r-schweitzer <50628828+r-schweitzer@users.noreply.github.com> Co-authored-by: coryhammon1 <coryhammon1@gmail.com> Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>

Fawke added 5 commits October 1, 2019 12:06

deprecate domain/referer type functions

fdda03f

delete modules that are using deprecated methods from utils.js

8d668a4

remove reference to getTopWindowLocation

5ceb485

sync with prebid-3.0 branch

06f77bb

remove test suite for getTopWindowLocation

5db6583

Fawke added the Prebid 3.0 label Oct 1, 2019

Merge branch 'prebid-3.0' into deprecations-utils.js

3b5f3fa

Fawke added the on hold label Oct 1, 2019

mike-chowla assigned idettman Oct 3, 2019

idettman added the needs update label Oct 3, 2019

Fawke added 3 commits October 9, 2019 16:04

add back md files of all deleted adapters

5af97ca

Merge branch 'deprecations-utils.js' of https://github.com/prebid/Pre…

0fc761c

…bid.js into deprecations-utils.js

add md files of deleted analytics adapters

9b19ef7

idettman approved these changes Oct 14, 2019

View reviewed changes

Fawke requested review from jaiminpanchal27 and jsnellbaker November 4, 2019 14:38

Fawke added 2 commits November 11, 2019 16:07

revise adapter list not following prebid-3.0 spec

abc354f

add adapters that are 3.0 compliant

8f1d27f

sumit116 mentioned this pull request Nov 26, 2019

Make all adapters https #4294

Merged

1 task

update deprecated adapter list

4f6c88a

idettman added the needs 2nd review Core module updates require two approvals from the core team label Dec 4, 2019

idettman assigned jaiminpanchal27 and unassigned idettman Dec 4, 2019

idettman unassigned jaiminpanchal27 Dec 4, 2019

idettman assigned Fawke Dec 4, 2019

sync with prebid-3.0

34b7d72

sync with prebid-3.0

7424c5b

jsnellbaker approved these changes Dec 10, 2019

View reviewed changes

jaiminpanchal27 approved these changes Dec 10, 2019

View reviewed changes

add back the rubicon skipped test

2c66fd8

sync with prebid-3.0

c2386fb

Fawke merged commit 3bb263b into prebid-3.0 Dec 11, 2019

jsnellbaker mentioned this pull request Dec 11, 2019

Prebid 3.0 #4580

Merged

1 task

bjorn-lw mentioned this pull request Dec 12, 2019

Fixes for Prebid 3.0 #4587

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecations utils.js #4249

Deprecations utils.js #4249

Fawke commented Oct 1, 2019 •

edited by idettman

Loading

mkendall07 commented Oct 1, 2019

idettman commented Oct 3, 2019 •

edited

Loading

idettman left a comment •

edited

Loading

anand-venkatraman commented Oct 15, 2019

lgtm-com bot commented Nov 11, 2019

lgtm-com bot commented Dec 2, 2019

idettman commented Dec 4, 2019

lgtm-com bot commented Dec 5, 2019

Fawke commented Dec 6, 2019

Fawke commented Dec 9, 2019 •

edited

Loading

lgtm-com bot commented Dec 10, 2019

jaiminpanchal27 left a comment

jaiminpanchal27 Dec 10, 2019

Fawke Dec 11, 2019

Fawke commented Dec 11, 2019

lgtm-com bot commented Dec 11, 2019

lgtm-com bot commented Dec 11, 2019

Deprecations utils.js #4249

Deprecations utils.js #4249

Conversation

Fawke commented Oct 1, 2019 • edited by idettman Loading

Type of change

Description of change

Please review but don't merge this time.

mkendall07 commented Oct 1, 2019

idettman commented Oct 3, 2019 • edited Loading

idettman left a comment • edited Loading

Choose a reason for hiding this comment

anand-venkatraman commented Oct 15, 2019

lgtm-com bot commented Nov 11, 2019

lgtm-com bot commented Dec 2, 2019

idettman commented Dec 4, 2019

lgtm-com bot commented Dec 5, 2019

Fawke commented Dec 6, 2019

Fawke commented Dec 9, 2019 • edited Loading

lgtm-com bot commented Dec 10, 2019

jaiminpanchal27 left a comment

Choose a reason for hiding this comment

jaiminpanchal27 Dec 10, 2019

Choose a reason for hiding this comment

Fawke Dec 11, 2019

Choose a reason for hiding this comment

Fawke commented Dec 11, 2019

lgtm-com bot commented Dec 11, 2019

lgtm-com bot commented Dec 11, 2019

Fawke commented Oct 1, 2019 •

edited by idettman

Loading

idettman commented Oct 3, 2019 •

edited

Loading

idettman left a comment •

edited

Loading

Fawke commented Dec 9, 2019 •

edited

Loading