Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update addEventListener in secureCreatives.js to window.addEventListener #4371

Closed
vkimcm opened this issue Oct 23, 2019 · 4 comments
Closed
Labels

Comments

@vkimcm
Copy link
Collaborator

vkimcm commented Oct 23, 2019

Description

addEventListener in listenMessagesFromCreative function in secureCreatives.js might need to be changed to window.addEventListener. We had some issues where request_ad messages from safeframe creatives where not being received, causing big discrepancies, and this update fixed the issue. (especially with connatix javascript)

Other information

@vkimcm vkimcm changed the title change addEventListener in secureCreatives.js to window.addEventListener update addEventListener in secureCreatives.js to window.addEventListener Oct 23, 2019
@stale
Copy link

stale bot commented Nov 6, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 6, 2019
@jsnellbaker jsnellbaker removed the stale label Nov 6, 2019
@stale
Copy link

stale bot commented Nov 20, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 20, 2019
@bretg
Copy link
Collaborator

bretg commented Nov 25, 2019

@vkimcm - I would suggest going ahead and making a code PR for this.

@stale stale bot removed the stale label Nov 25, 2019
@stale
Copy link

stale bot commented Dec 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants