Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Units Tests to the Framework #45

Closed
prebid opened this issue Sep 22, 2015 · 5 comments
Closed

Add Units Tests to the Framework #45

prebid opened this issue Sep 22, 2015 · 5 comments
Assignees
@protonate

Comments

@prebid
Copy link
Collaborator

prebid commented Sep 22, 2015

No description provided.

@johngeorgewright
Copy link
Contributor

👍 Any thoughts on how you intend on doing this?

We've been looking to possibly move our code base on to a framework like this and we've been keeping a close eye on Prebid.js. However, I'm going to find it hard to keep this project a contender until I can prove that it will work and continue to work 🐛 free as more people start maintaining it. A high percentage of test coverage will help dramatically.

@hjeong12
Copy link
Contributor

@johngeorgewright Hi John, I'm working on this using mocha.

@prebid
Copy link
Collaborator Author

prebid commented Oct 20, 2015

@johngeorgewright: We're committed to keeping the code base bug free and well maintained. Since the codebase now is stable and almost feature complete, we're switching effort to writing unit tests. Would like to periodically check with you to see how comfortable you're with the test coverage.

mkendall07 added a commit that referenced this issue Jan 5, 2016
@mkendall07
#45 - add automated unit test to gulp serve task
3a436e2
@protonate
Copy link
Collaborator

PR #174 adds support for Karma and Istanbul for running tests and generating reports, and tests will be added soon to bring up coverage to reliable levels.

@protonate protonate self-assigned this Feb 8, 2016
@protonate
Copy link
Collaborator

Closing as we now have test coverage in place and will be continuing to add additional tests going forward.

marian-r pushed a commit to aol/Prebid.js that referenced this issue Nov 17, 2016
Merge pull request prebid#45 in AOLP_ADS_JS/prebid.js from release/1.…
6d5f6f1 
…4.2 to master

* commit '585bbcf3fccf965b442507396b1e8c301ebb3e23':
  Renamed unit test
  Updated CHANGELOG
  Fixed reporting refreshed ad units in AOL analytics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@protonate protonate

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@johngeorgewright @protonate @hjeong12