Timeout reporting is never called #489
Comments
|
@therazor |
|
I see, that would certainly work, but is there any reason it's not called automatically when a timeout is provided to Perhaps worth updating the examples? |
|
I don't recall why it's not hooked it. It might have been dropped accidentally during a refactor. |
|
I'll submit a PR soon. Related issue: #272 |
Merged
protonate
pushed a commit
that referenced
this issue
Aug 12, 2016
* gather bidders without responses during timeout callback. Fixes #489 - fixes bidders not being recorded as timed out if there is never a response - fixes `getTimedOutBidders()` always returning an empty array when only one bidder is used That happened because the function returned `slots requested - slots that replied`, but was called after timed out slots were marked as having replied before timeout - fixes `bidManager` ignoring the timeout override passed to `$$PREBID_GLOBAL$$.requestBids` * remove timeout triggering public function This is not necessary anymore as bidder timeouts are now handled automatically * remove unused event * rewrite timeout test to be async * handle responses arrived after timeout - mitigates #311 * notify the callback of timeout and delegate its event triggering * bid timeout must be executed BEFORE `_bidsReceived.push` This ensures that `getTimedOutBidders` recognises the current response as timed out
protonate
pushed a commit
that referenced
this issue
Aug 20, 2016
* gather bidders without responses during timeout callback. Fixes #489 - fixes bidders not being recorded as timed out if there is never a response - fixes `getTimedOutBidders()` always returning an empty array when only one bidder is used That happened because the function returned `slots requested - slots that replied`, but was called after timed out slots were marked as having replied before timeout - fixes `bidManager` ignoring the timeout override passed to `$$PREBID_GLOBAL$$.requestBids` * remove timeout triggering public function This is not necessary anymore as bidder timeouts are now handled automatically * remove unused event * rewrite timeout test to be async * handle responses arrived after timeout - mitigates #311 * notify the callback of timeout and delegate its event triggering * bid timeout must be executed BEFORE `_bidsReceived.push` This ensures that `getTimedOutBidders` recognises the current response as timed out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We are using the GA analytics adapter with a 1s timeout.
Out of a few million page impressions, we cannot see any prebid timeout event recorded in GA.
The implementation seems to be there, but the triggering function
sendTimeoutEvent()is never called.There are no references in the code other than inside tests.
Anything I'm missing?
The text was updated successfully, but these errors were encountered: