Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few adapters not reading user id data from bidRequest.userId object #5234

Closed
Fawke opened this issue May 14, 2020 · 9 comments
Closed

Few adapters not reading user id data from bidRequest.userId object #5234

Fawke opened this issue May 14, 2020 · 9 comments

Comments

@Fawke
Copy link
Contributor

Fawke commented May 14, 2020

Description

We added GDPR Enforcement module for TCF v2.0 recently. One of the features of this module states that, if a user doesn't consent to purpose 4, Prebid won't send userId data to the adapter. We request all the adapters listed here to use standard Prebid api/code when available and not add their own custom code to access user id.
Purpose 4 implementation details are still in discussion and enforcement rules may change.

User Ids include - user.buyeruid, user.id, user.ext.eids, user.ext.digitrust and device.ifa, device.macsha1, device.macmd5, device.dpidsha1, device.dpidmd5, device.didsha1, device.didmd5

Find more details about TCF enforcement here

Prebid.js provides all configured userIds to adapters under the bidRequest.userId / bidRequest.userIdAsEids object. To enforce purpose 4, these two objects will not be passed to the adapters if consent is not given.

In light of this, all adapters will have to read user id information from either of the two objects mentioned above.

Few adapters have been found populating user id values from other sources. If you are a maintainer of any of the adapters listed below, please submit a PR in which you read the values from bidRequest.userId or bidRequest.userIdsAsEids object.

1. user.buyeruid
2. user.id
3. digitrust ID

I've few few bid adapters read the value of Digitrust ID from the window object. Should they not read it from bidRequest[0].bidder[].userId.digitrust ?

4. user.ext.eids
  • prebidServerBidAdapter.js - Reads this value from bids.0.userIdAsEids. Check this line
5. user.ext.digitrust
  • Refer to 3 digitrust ID
6. device.ifa
  • platformioBidAdapter.js - Reads this value from bid[].params. Check this line @barslev @varashellov
  • windtalkerBidAdapter.js - (Almost identical code to platformioBidAdapter.js) Reads this value from bid[].params. Check this line @barslev

Related PR - #5228

@Fawke Fawke changed the title Few adapters not reading user id data from **bidRequest.userId** object Few adapters not reading user id data from bidRequest.userId object May 14, 2020
@pm-harshad-mane
Copy link
Contributor

Thanks @Fawke , we are working on it, code changes are in QA

@jddeleon
Copy link
Contributor

Tagging @susyt for GumGum adapter.

@goosemanjack
Copy link
Contributor

Hold off on any further DigiTrust integration work. We are evaluating some extensive changes that may be breaking.

@patmmccann
Copy link
Collaborator

also the ix adapter includes // RTI ids will be included in the bid request if the function getIdentityInfo() is loaded // and if the data for the partner exist if (window.headertag && typeof window.headertag.getIdentityInfo === 'function') { let identityInfo = window.headertag.getIdentityInfo(); if (identityInfo && typeof identityInfo === 'object') { for (const partnerName in identityInfo) { if (identityInfo.hasOwnProperty(partnerName)) { let response = identityInfo[partnerName]; if (!response.responsePending && response.data && typeof response.data === 'object' && Object.keys(response.data).length) { userEids.push(response.data); } } } }

@robertrmartinez
Copy link
Collaborator

I have created an internal ticket for the Rubicon bid adapter changes.

@patmmccann
Copy link
Collaborator

fyi @ix-prebid-development

@ix-prebid-support
Copy link
Contributor

@patmmccann

While it is correct that the IX Adapter reads Authenticated Signals made available on the page by the IX Identity Library javascript, the IX Identity Library is already fully privacy compliant with GDPR (TCF 1 and 2) as well as CCPA. Therefore, it's our position that:

  • When we source IDs from the IX Identity Library - these IDs are subject to consent guidance that is collected and consumed by the IX Identity Library
  • When we source IDs from the Prebid user module - these IDs are subject to consent guidance that is collected and consumed by Prebid

This is in alignment with the desire of Publishers who choose to use the IX Identity Library as well as Prebid.

@stale
Copy link

stale bot commented Jul 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 11, 2020
@bretg bretg removed the stale label Jul 16, 2020
@stale
Copy link

stale bot commented Aug 1, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 1, 2020
@stale stale bot closed this as completed Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants