Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass video.placement through to Prebid Server #5687

Closed
bretg opened this issue Sep 2, 2020 · 1 comment · Fixed by #5716
Closed

Pass video.placement through to Prebid Server #5687

bretg opened this issue Sep 2, 2020 · 1 comment · Fixed by #5716
Assignees
@mike-chowla
Labels
feature

Comments

@bretg
Copy link
Collaborator

bretg commented Sep 2, 2020

Type of issue

Enhancement

Description

Prebid Server doesn't get any indication of whether a video request is instream or outstream, and what kind of "placement" it is.

Proposal

  1. We modify the PrebidServerBidAdapter to support setting imp[].video.placement
  • if AdUnit.mediaTypes.video.placement is defined send that as imp[].video.placement
  • else if AdUnit.mediaTypes.video.context="instream", send imp[].video.placement=1
  1. We modify the Prebid.org documentation to suggest defining placement when setting outstream.

https://docs.prebid.org/prebid-video/video-getting-started.html
https://docs.prebid.org/dev-docs/show-outstream-video-ads.html
@bretg bretg added the feature label Sep 2, 2020
@mike-chowla
Copy link
Contributor

Approach looks to good to me.

robertrmartinez added a commit that referenced this issue Sep 8, 2020
@robertrmartinez
implement issue #5687
f3f99c2
@robertrmartinez robertrmartinez mentioned this issue Sep 8, 2020
Merged
1 task
@robertrmartinez robertrmartinez linked a pull request Sep 8, 2020 that will close this issue
PBS Bid Adapter: Pass video.placement when context is instream (#5687) #5716
Merged
1 task
bretg pushed a commit that referenced this issue Sep 10, 2020
@robertrmartinez
implement issue #5687 (#5716)
c01cab1
BrightMountainMediaInc pushed a commit to BrightMountainMediaInc/Prebid.js that referenced this issue Sep 14, 2020
@robertrmartinez
implement issue prebid#5687 (prebid#5716)
c9f52b7
BrightMountainMediaInc pushed a commit to BrightMountainMediaInc/Prebid.js that referenced this issue Sep 14, 2020
Revert "implement issue prebid#5687 (prebid#5716)"
a0c3bb7 
This reverts commit c9f52b7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mike-chowla mike-chowla

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PBS Bid Adapter: Pass video.placement when context is instream (#5687) prebid/Prebid.js
2 participants
@bretg @mike-chowla