-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: native rendering without specifying a url of the renderer #6695
Comments
I would generally agree with you and argue that the custom renderer should be consistently implemented and supported on all mediatypes . I also think it would make sense that if |
Same issue for us. We are using the renderer for native ads without url. |
@bjorn-lw we have been talking about splitting off a sub-committee for native to get more expertise focused on issues like this. Sounds like this would be a +1 for that on learning more how native is actually being used in the wild. |
@guiann you know more about prebid native rendering than I do. Is this a problem you come across also? |
Magnite is currently reviewing the native rendering implementation as well as other native implementation challenges of pbjs and will be submitting a comprehensive proposal for the community to review in the coming weeks. Once submitted this would probably be an opportune time to form a sub-committee if others deem it to be necessary / meaningful . |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@naegelin curious for an update? |
Hey @patmmccann I am no longer with Magnite - I would check with @caitlinwright123 |
The src/Renderer.js file is for outstream videos. I do not think this should be permitted. I propose a check that allows this "renderer" only for videos here. I do think however enabling native to check for a render function is fine, but only when the mediaType is native. |
I should mention that we're also using So while it might make sense to add another method to implement the same behavior, I for sure hope that support of (apologize if I misunderstood the suggestion) |
looks to be solved by #9769 |
Type of issue
Question about native rendering
Description
Several of our customers who run native ads don't use GAM/AppNexus or sometimes not even an ad server at all.
This makes the proposed rendering techniques (https://docs.prebid.org/prebid/native-implementation.html) unnecessary complicated since they often already have existing functionality for rendering native ads via JavaScript from before header bidding when they had direct integrations with Native ad providers.
To simplify setup, we use the existing render functionality in Prebid.js by setting
mediatypes.native.renderer = { url: 'someurl', render: ...renderfunction on customer's site }
which works really well with only minor modifications to the customer's already existing rendering code.
We used to set url to only '//' since the rendering code was already present on site and no external script needed to be loaded, but this seem to have stopped working with #6422. Now we simply point to a minimal CDN-hosted js file, which works even though it's not really optimal.
So the question(s):
I could certainly volunteer to do some/all changes required (if any) above, but if it's against prebid's design principles I guess it's not a good idea to start working on it.
The text was updated successfully, but these errors were encountered: