Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: native rendering without specifying a url of the renderer #6695

Closed
bjorn-lw opened this issue May 4, 2021 · 11 comments
Closed

Comments

@bjorn-lw
Copy link
Contributor

bjorn-lw commented May 4, 2021

Type of issue

Question about native rendering

Description

Several of our customers who run native ads don't use GAM/AppNexus or sometimes not even an ad server at all.

This makes the proposed rendering techniques (https://docs.prebid.org/prebid/native-implementation.html) unnecessary complicated since they often already have existing functionality for rendering native ads via JavaScript from before header bidding when they had direct integrations with Native ad providers.

To simplify setup, we use the existing render functionality in Prebid.js by setting

mediatypes.native.renderer = { url: 'someurl', render: ...renderfunction on customer's site }

which works really well with only minor modifications to the customer's already existing rendering code.

We used to set url to only '//' since the rendering code was already present on site and no external script needed to be loaded, but this seem to have stopped working with #6422. Now we simply point to a minimal CDN-hosted js file, which works even though it's not really optimal.

So the question(s):

  1. Is this way of rendering native ads something that will continue to be supported by Prebid or are we abusing the renderer functionality and it may break at any time? My main concern is that everywhere, even though this practically works for native, it's only mentioned together with "outstream". In Renderer.js, it explicitly tests for 'mediatypes.video.renderer', but not 'mediatypes.native.renderer'. The Renderer.js moduleCode is also set to "outstream".
  2. If this functionality is OK to continue using, would it be acceptable to make it possible to omit the url parameter if the rendering code is already present/loaded on site?
  3. And finally, if it will continue to be supported it would be nice to also document it.

I could certainly volunteer to do some/all changes required (if any) above, but if it's against prebid's design principles I guess it's not a good idea to start working on it.

@naegelin
Copy link
Contributor

naegelin commented May 6, 2021

I would generally agree with you and argue that the custom renderer should be consistently implemented and supported on all mediatypes . I also think it would make sense that if renderer.render provides a function without a renderer.url then prebid should assume that the function is available to prebid from the page.

@vlouppe
Copy link

vlouppe commented Jun 29, 2021

Same issue for us. We are using the renderer for native ads without url.

@ChrisHuie
Copy link
Collaborator

@bjorn-lw we have been talking about splitting off a sub-committee for native to get more expertise focused on issues like this. Sounds like this would be a +1 for that on learning more how native is actually being used in the wild.

@ChrisHuie
Copy link
Collaborator

@guiann you know more about prebid native rendering than I do. Is this a problem you come across also?

@naegelin
Copy link
Contributor

naegelin commented Aug 2, 2021

Magnite is currently reviewing the native rendering implementation as well as other native implementation challenges of pbjs and will be submitting a comprehensive proposal for the community to review in the coming weeks. Once submitted this would probably be an opportune time to form a sub-committee if others deem it to be necessary / meaningful .

@naegelin naegelin self-assigned this Aug 2, 2021
@bx2 bx2 added the question label Dec 8, 2021
@stale
Copy link

stale bot commented Jan 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 8, 2022
@ChrisHuie ChrisHuie removed the stale label Jan 12, 2022
@patmmccann
Copy link
Collaborator

@naegelin curious for an update?

@naegelin
Copy link
Contributor

Hey @patmmccann I am no longer with Magnite - I would check with @caitlinwright123

@bretg bretg assigned jlustig11 and unassigned naegelin and bretg Jul 19, 2022
@jlustig11
Copy link

The src/Renderer.js file is for outstream videos. I do not think this should be permitted. I propose a check that allows this "renderer" only for videos here.

I do think however enabling native to check for a render function is fine, but only when the mediaType is native.

@patmmccann patmmccann changed the title Question about native rendering Feature request: native rendering without specifying a url of the renderer Mar 27, 2023
@samuel-palmer-relevant-digital
Copy link
Contributor

samuel-palmer-relevant-digital commented May 10, 2023

The src/Renderer.js file is for outstream videos. I do not think this should be permitted. I propose a check that allows this "renderer" only for videos here.

I should mention that we're also using mediaTypes.native.renderer as it simplifies integration on sites a lot and works well with existing prebid line items without having to use special native creatives.

So while it might make sense to add another method to implement the same behavior, I for sure hope that support of mediaTypes.native.renderer isn't "suddenly" dropped.

(apologize if I misunderstood the suggestion)

@patmmccann
Copy link
Collaborator

looks to be solved by #9769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

9 participants