-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ORTB Native refinements #8764
Comments
I think it is fair to sever 4 from this and continue to track on #6695 |
Ok, removed the 4th item. |
Hi @bretg , No problem in checking that it's a positive number. I'm fine with points 2 and 3. |
PMC: Agree on 1, implement it. for 2 and 3, mark these features as deprecated and log a message to the console if they are used. |
closed with 11481 |
Type of issue
enhancement
Description
While updating the ORTB native docs, generated a list of proposed changes/enhancements:
1. Validate Asset IDs
ORTB requires asset IDs, but this is mainly for linking response assets to the request assets. At one point we discussed having PBJS fill in missing asset IDs, but this has been considered problematic. Instead, PBJs should validate the asset ID:
If the asset ID doesn't exist or the assetID is negative, console log an error and remove this adunit from the auction.
2. Remove the sendTargetingKeys flag
This is the old option that tells Prebid to send all the hb_native KVPs to the adserver. That shouldn't happen anymore now that we have better ways to transmit the asset data at render time.
Proposal:
3. Error if Native "types" are specified
'Type' is a sort of 'macro' introduced in an early version of PBJS that expands to a set of assets. This is Prebid-only behavior meant to be friendly, but doesn't fit well with the ORTB approach. A “type” is like a macro that defines a group of assets. The only value supported is ‘image’, which implies the following assets: image, title, sponsoredBy, clickUrl, body, icon, and cta. The first 4 are required attributes.
Proposal:
if both 'types' and 'ortb' are specified in adunit.mediatypes.native, console log an error and remove this adunit from the auction.
Heads up @muuki88 , @patmmccann , @dgirardi
The text was updated successfully, but these errors were encountered: