Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bid.timeToRespond ends up being equal to the responseTimestamp value #729

Closed
ghost opened this issue Oct 20, 2016 · 3 comments
Closed

bid.timeToRespond ends up being equal to the responseTimestamp value #729

ghost opened this issue Oct 20, 2016 · 3 comments

Comments

@ghost
Copy link

ghost commented Oct 20, 2016

Type of issue

Bug

Description

In bidmanager.js, addBidResponse function, the bid.requestTimestamp can be set to null if pbjs._bidsRequested doesn't contain the bidder in getBidSetForBidder. This causes bid.timeToRespond to end up as a huge number.

Steps to reproduce

Expected results

Actual results

Platform details

Other information
@dugwood
Copy link
Contributor

dugwood commented Oct 22, 2016

Do you forgot to add the bidder in the call to pbjs.addAdUnits? Can you provide a test case?

@dugwood
Copy link
Contributor

dugwood commented Oct 22, 2016

Also it's a duplicate of #643 IMHO

This was referenced Oct 22, 2016
Merged
Closed
@mkendall07
Copy link
Member

@cliffliang closing this as a duplicate of #643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkendall07 @dugwood