Fix selected bid for the right timestamp #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protonate
approved these changes
Oct 24, 2016
| return $$PREBID_GLOBAL$$._bidsRequested.find(bidSet => bidSet.bidderCode === bidder) || { start: null, requestId: null }; | ||
| function getBidSet(bidder, adUnitCode) { | ||
| return $$PREBID_GLOBAL$$._bidsRequested.find(bidSet => { | ||
| return bidSet.bids.filter(bid => bid.bidder === bidder && bid.placementCode === adUnitCode).length > 0; |
There was a problem hiding this comment.
This will work with the approach we are now taking with queued bid requests -- bid requests and responses will be removed from the _bidsRequested and _bidsReceived arrays when that placement is part of the outgoing bid request.
|
Thanks for the merge! I'll switch back to the master today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
The requested bid returned in
addBidResponseisn't the good one, because it doesn't filter by adUnit.Other information
#729 #700
@protonate that will be the last fix I'll do a PR for, as I don't see other errors I had before (requested !== received in the
bidsBackAllfunction). Once #735 and this one are merged, I'll have a new look at everything (it's really difficult to fix many things somehow related, in multiple fixes).