-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PBS Bid Adapter: remove site object when app is present #7329
Labels
Comments
might make sense for the validations module to also note this issue |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
fix in #9258 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Type of issue
enhancement
Description
Prebid Server chokes when an OpenRTB request contains both site and app sections. Since OpenRTB says this is an invalid scenario, that committee has determined in prebid/prebid-server#1947 that the right solution is to prevent it from happening.
Steps to reproduce
The instructions at https://docs.prebid.org/faq/prebid-server-faq.html#how-can-i-use-prebid-server-in-a-mobile-app-post-bid-scenario define how to use PBJS for App in a Post-Bid scenario.
But it doesn't actually work because the PBS Bid Adapter also includes site.
So we need to update the PBS Bid adapter to:
cat
) are in the app objectNote: we don't consider this a breaking change because PBS is already failing on this if it's happening. We're just moving the validation to the client side to save everyone the headache.
The text was updated successfully, but these errors were encountered: