-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling requests containing both app and site #1947
Comments
I am not keen on Prebid Server accepting an invalid OpenRTB request and altering the request to make it conform. As a counter proposal for this case, let's have Prebid.js perform the transformation you are describing before sending the request. |
Understood that this would be a preferable solution, but keep in mind that changes to PBJS take literally years to propagate out to all publishers. That said, any pub affected by this issue would have adequate incentive to upgrade. So it might be ok to go this way. |
I think we should do the change in Prebid.js in any case, to push the visibility back into the prebid server adapter at least. Silently dropping data makes debugging hard, if the code exists in the PBJS adapter, at least someone can trace the change happening there. If it takes too long for publishers to update, we could consider mirroring the change in PBS, perhaps with a config flag so hosts that prefer to enforce the OpenRTB standard can do that, and hosts that wish accommodate the bad PBJS behavior can also do that. |
Discussed in the Prebid Server Committee. We would prefer for this to be implemented in PBJS and to use this as an incentive for publishers to update their PBJS versions if they encounter the issue. There was also the suggestion for the error message from PBS to specify the minimum version of PBJS which addresses this situation. |
Opened a PBJS issue. Closing this one. |
It's a valid use case in PBJS post-bid to define something like:
However, Prebid Server reject any request containing both "site" and "app" which is specifically forbidden by ORTB2.5.
We propose that PBS accept this scenario and drop
site
if bothsite
andapp
are present, adding a warning to the debug trace.The text was updated successfully, but these errors were encountered: