Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebid.js 7: update pbsBidAdapter to use imp.ext.prebid.bidder.BIDDER #7954

Closed
bretg opened this issue Jan 21, 2022 · 3 comments · Fixed by #8513
Closed

Prebid.js 7: update pbsBidAdapter to use imp.ext.prebid.bidder.BIDDER #7954

bretg opened this issue Jan 21, 2022 · 3 comments · Fixed by #8513

Comments

@bretg
Copy link
Collaborator

bretg commented Jan 21, 2022

Type of issue

refactoring

Description

Some time back, the Prebid Server committee moved the ortb2 location of bidder parameters from imp[].ext.BIDDER to imp[].ext.prebid.bidder.BIDDER. This was covered in prebid/prebid-server#1478

We would like to move Prebid.js to utilize this new location in version 7 in the pbsBidAdapter

@dgirardi
Copy link
Collaborator

This does not look like a breaking change to me; it should be entirely invisible to everything except the PBS adapter. But, does the server advertise support for the new location? Or can we assume that every PBS instance now understands it?

@patmmccann
Copy link
Collaborator

Or can we assume that every PBS instance now understands it?

Known host companies now understand it, but old version of PBS may not, and we're not sure how many exist.

@patmmccann
Copy link
Collaborator

Code to fix appears to be here

const ext = adUnit.bids.reduce((acc, bid) => {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

5 participants