Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebid 7 - a proposed list of breaking changes #7796

Closed
patmmccann opened this issue Dec 2, 2021 · 16 comments · Fixed by #8530
Closed

Prebid 7 - a proposed list of breaking changes #7796

patmmccann opened this issue Dec 2, 2021 · 16 comments · Fixed by #8530
Assignees
Labels
7.0 API Change pinned won't be closed by stalebot

Comments

@patmmccann
Copy link
Collaborator

patmmccann commented Dec 2, 2021

Type of issue

A Proposed and working list of breaking changes to include in Prebid 7 - target release Late May 2022

The list

Complete:

delete userid targeting module #8226
delete nextroll #8150
Remove Appnexus analytics #8330
delete floc #8225
#7522 Confirmation from the Yahoo team indicates to remove onevideo (aol in next version)
Adapters accepting interstitial flag must accept ortb2 instl param #5917
Remove dmx #8417
change defaults on #8129
delete halo as per #7938
#7651 site.content.data on specific auctions
Fold trustx into Grid #8321
remove adlive bid adapter
delete sortable adapters #8263
#8437 -- delete appnexus aliases
#8279 bid modules will not be able to use storage manager unless whitelisted by pubs in config
Remove akamai id module
fix bcats to read from ortb2 everywhere #7925
#7853 default usp to iab
#8235 remove stored auction response
deprecate getLegacyFpd #8283

Adapters accepting position must accept it as per conventions defined at #5578

Adapters known to be using http1 bid endpoints in violation of bidder module rules will get warnings in their adapter documentation; user sync endpoints in http1 will not incur the warning at this time.

Drop tcf1 #7781

Finish up referrer changes #5637 #8450

prevent Prebid from loading twice - #8374

#7954 update pbsBidAdapter to use imp.ext.prebid.bidder.BIDDER

Update all documentation related to FPD to follow up #8283 and #7651

@josepowera
Copy link

Proposal
Make universal OpenRTB and ID module that BidAdapters and ID providers can "inherit"

Make a universal OpenRTB 2.5 bidding module, that minimizes what bidder adapter has to do.... adapter would only define:
-httpEndpoint for bidding,
-httpEndpoint for cookieSyncs
-gvlID
-supported mediatypes (banner, native, video, audio)
-supported browser countries (most smaller bidders are teritory specific) (that would required geoIp module - can be serverside via JSON call)

If most bidders move to this simplified adapter overhead of maintaining (and pull requests) for > adapters would be greatly minimized.


Same goes for ID providers... most providers are simple JSON calls to serverside

If provider just defines
-httpEndpoint for ID resolving
-euid domain
-cookie name
-TTL

while all rest code is "inherited" from universal general ID module.
Most providers could use this general ID module

@gglas
Copy link

gglas commented Dec 6, 2021

@slimkrazy @adam-browning would you mind reviewing the second item? We think this would be an opportune time to consolidate, let us know your feedback and if we should expect it.

@patmmccann
Copy link
Collaborator Author

@josepowera this is a great idea but not a breaking change; it could be merged with any release.

@stale
Copy link

stale bot commented Jan 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 8, 2022
@ChrisHuie ChrisHuie removed the stale label Jan 12, 2022
@patmmccann
Copy link
Collaborator Author

delete floc adapter

@patmmccann
Copy link
Collaborator Author

delete halo as requested in #7938

@jsnellbaker jsnellbaker added the pinned won't be closed by stalebot label Feb 7, 2022
@dgirardi
Copy link
Collaborator

We may want to include part of #8130; specifically, redefinition of "bidLimit" and "sendStandardTargeting" to address outstanding bug reports about them.

@antlauzon
Copy link
Contributor

Please allow additional time for Halo removal. A formal PR will be submitted.

@patmmccann
Copy link
Collaborator Author

patmmccann commented Mar 22, 2022

@anthonylauzon could you be more specific? Are you looking for days, months, years? Do you want this to be a part of prebid 8? This was only included at your request. Target release is May; Is that too soon?

how about this, if you want it in 7, we'll rely on you to submit the pr or not. If you don't it will have to wait for prebid 8, which may or may not be in 2022

@antlauzon
Copy link
Contributor

Your proposal works. We will handle submitting the PR during the lifetime of the future version.

@patmmccann
Copy link
Collaborator Author

@anthonylauzon could you submit the delete halo pr soon? We have double the maintenance surface now.

@antlauzon
Copy link
Contributor

antlauzon commented May 3, 2022

We are working towards the removal PR and will submit it once we are sure all migrations are complete.

@antlauzon
Copy link
Contributor

This will likely occur during the lifetime of Prebid 7. We wanted to make sure to allow at least a major version for migrations to complete.

@patmmccann
Copy link
Collaborator Author

patmmccann commented May 4, 2022

@anthonylauzon the purpose of the major release is to notify publishers they might need to make build or configuration changes; we don't need to wait for all publishers to complete changes before releasing, the release serves to notify them to begin that work. Publishers are used to changing things at major release time. In fact, you requesting them to redo your integration before upgrade doubles their work.

If you must have Halo around though, please just make halo module completely import hadron and change hadron to default to variable names hadron unless it is imported by Halo. We're trying to reduce code surface.

@antlauzon
Copy link
Contributor

@patmmccann understood that you would like to reduce code surface. We're targeting Prebid 8 for all partners to have completed migrating. As we iterate on Hadron, we would prefer to leave the Halo modules unmodified until we can submit a formal removal PR.

@patmmccann
Copy link
Collaborator Author

Hi @anthonylauzon ; we plan to go ahead and remove halo in 7 in that case. It seems we're just talking past each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7.0 API Change pinned won't be closed by stalebot
Projects
Development

Successfully merging a pull request may close this issue.

7 participants