Prebid 7: Change default bidder access to storage manager #8279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
added
needs 2nd review
3link
reviewed
Apr 14, 2022
src/storageManager.js
Outdated
| @@ -31,7 +31,7 @@ export function newStorageManager({gvlid, moduleName, bidderCode, moduleType} = | |||
| return false; | |||
| } | |||
| const storageAllowed = bidderSettings.get(bidderCode, 'storageAllowed'); | |||
| return storageAllowed == null ? false : !storageAllowed; | |||
| return storageAllowed == null ? true : !storageAllowed; | |||
There was a problem hiding this comment.
@patmmccann This change seems to have no effect on the behaviour of userId modules. Can you please confirm?
There was a problem hiding this comment.
confirmed, this is intended to only affect bidders
1 task
10 tasks
ChrisHuie
approved these changes
May 11, 2022
|
Will there also be a doc change to section 2.6 of bidderSettings? |
ncolletti
reviewed
May 12, 2022
|
ncolletti
added
LGTM
and removed
needs 2nd review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default of #7280 as per #7796
It requires that bidders needing access to storage manager are whitelisted in configuration. It does not affect the behavior of other module types.