Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit event when targeting is sent to DFP (setTargetingForGPTAsync) #858

Closed
itayo155 opened this issue Dec 6, 2016 · 3 comments
Closed
Assignees

Comments

@itayo155
Copy link
Contributor

itayo155 commented Dec 6, 2016

Type of issue

feature request

Description

Currently, there's no reliable way to know when an auction has actually ended, i.e. the point after which no bids would participate in the auction.
The existing AUCTION_END event is, in many cases, unreliable for this use because most setups do not use prebid's timeout field for ending the auction - they use external setTimeout instead, and/or are calling setTargetingForGPTAsync directly.

The suggestion is to emit a new event ("SET_TARGETING_CALLED") when setTargetingForGPTAsync is called. This indicates that all bids have been collected and actually sent away.
Of course, there are some implementations in which this function is never called/ is not a reliable indicator, however it should work in the vast majority of cases.

This event would be useful for bidders, allowing them to optimize response times, which in turn would maximize bid-rate for publishers.
Since the event would contain no sensitive information regarding the auction itself or its result, it should be ok for access by bidders.

Other information

Related:
#494 - details the current conditions for emitting AUCTION_END

@itayo155
Copy link
Contributor Author

Following up - any comments here? would be happy to submit a PR if this makes sense.

@protonate
Copy link
Collaborator

@itayo155 PRs are always welcome, thanks.

@matthewlane
Copy link
Collaborator

Closing with #873 now in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants