Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event for: auctionEnd (3 actions called but it only displays 2 "auctionEnd" events) #494

Closed
mercuryyy opened this issue Jul 30, 2016 · 4 comments
Assignees

Comments

@mercuryyy
Copy link
Contributor

mercuryyy commented Jul 30, 2016

So this might be normal operation but i think im missing something here, i have 3 ad units set, they are all showing they got a bid returned but when adx,adsense wins the action i only see 2

"MESSAGE: Emitting event for: auctionEnd"

now in some cases i will see rubicon win all 3 ad units and render the tag and display correctly so im not sure why its not show 3 "MESSAGE: Emitting event for: auctionEnd"

P.S same behavior in 0.11.0 stable.

INFO: Prebid.js v0.12.0-pre loaded
pb.js:1 INFO: Invoking pbjs.setPriceGranularity : params : ["medium"]
pb.js:1 INFO: Invoking pbjs.addAdUnits : params : [Array[3]]
pb.js:1 INFO: Invoking pbjs.requestBids : params : [Object]
pb.js:1 MESSAGE: Emitting event for: auctionInit
pb.js:1 MESSAGE: CALLING BIDDER ======= rubicon
pb.js:1 MESSAGE: Emitting event for: bidRequested
pb.js:1 MESSAGE: Rubicon Project bidding complete: 1502
pb.js:1 MESSAGE: Emitting event for: bidAdjustment
pb.js:1 MESSAGE: Emitting event for: bidResponse
pb.js:1 MESSAGE: Emitting event for: bidAdjustment
pb.js:1 MESSAGE: Emitting event for: bidResponse
pb.js:1 MESSAGE: Emitting event for: bidAdjustment
pb.js:1 MESSAGE: Emitting event for: bidResponse
pb.js:1 INFO: Invoking pbjs.setTargetingForGPTAsync
MESSAGE: Attempting to set key value for slot: div-gpt-ad-xxx-0 key: hb_bidder value: rubicon
pb.js:1 MESSAGE: Attempting to set key value for slot: div-gpt-ad-xxx-0 key: hb_adid value: xxx
pb.js:1 MESSAGE: Attempting to set key value for slot: div-gpt-ad-xxx-0 key: hb_pb value: 0.60
pb.js:1 MESSAGE: Attempting to set key value for slot: div-gpt-ad-xxx-0 key: hb_size value: 300x250
pb.js:1 MESSAGE: Attempting to set key value for slot: div-gpt-ad-xxx-1 key: hb_bidder value: rubicon
pb.js:1 MESSAGE: Attempting to set key value for slot: div-gpt-ad-xxx-1 key: hb_adid value: xxx
pb.js:1 MESSAGE: Attempting to set key value for slot: div-gpt-ad-xxx-1 key: hb_pb value: 0.40
pb.js:1 MESSAGE: Attempting to set key value for slot: div-gpt-ad-xxx-1 key: hb_size value: 728x90
pb.js:1 MESSAGE: Attempting to set key value for slot: div-gpt-ad-xxx-0 key: hb_bidder value: rubicon
pb.js:1 MESSAGE: Attempting to set key value for slot: div-gpt-ad-xxx-0 key: hb_adid value: xxx
pb.js:1 MESSAGE: Attempting to set key value for slot: div-gpt-ad-xxx-0 key: hb_pb value: 0.80
pb.js:1 MESSAGE: Attempting to set key value for slot: div-gpt-ad-xxx-0 key: hb_size value: 728x90
pb.js:1 MESSAGE: Prebid auction cleared
pb.js:1 MESSAGE: Emitting event for: auctionEnd
pb.js:1 MESSAGE: Prebid auction cleared
pb.js:1 MESSAGE: Emitting event for: auctionEnd

@jaiminpanchal27 jaiminpanchal27 self-assigned this Aug 2, 2016
@jaiminpanchal27
Copy link
Collaborator

@mercuryyy
In current implementation, we have 3 scenarios where we emit this AUCTION_END event.

  1. from requestBids function after timeout occurs
  2. when all bids are back
  3. if any bid response comes after timeout

This is kind of confusing, AUCTION_END event should be called once only, so we will correct this behaviour in next release. Thanks for notifying this to us.

@mercuryyy
Copy link
Contributor Author

mercuryyy commented Aug 3, 2016

@jaiminpanchal27 i was troubleshooting this for a few hours, i tried running it on 0.11 and 0.12.pre same behavior.

My main problem is i can't really tell if im loosing impressions. dfp adx,adsense is at 0.6 avg now only rubicon is bidding out of 8,000,000 actions they reported they bidded on 6,000,000 but only won a fraction of that. (500,000) but their avg cpm for paid bids is 1.4, a lot higher then adx,adsense 0.6 i would imagine it would balance out giving rubicon more impressions at less cpm to make adx compete

i have 200 line items 0.10 up to 20$ all are reporting impressions.

So im not sure exactly whats going on but i'll try the next public release and report back.

Thanks.

protonate pushed a commit that referenced this issue Aug 17, 2016
…#502)

* #494 fix. AUCTION_END event was getting emitted in multiple scenarios

* Fixed failing test case

* Fixed jshint error

* Moving clearAuction to finally after processing callback
@protonate
Copy link
Collaborator

This should now be resolved in master, closing.

protonate pushed a commit that referenced this issue Aug 20, 2016
…#502)

* #494 fix. AUCTION_END event was getting emitted in multiple scenarios

* Fixed failing test case

* Fixed jshint error

* Moving clearAuction to finally after processing callback
@GeneGenie
Copy link
Contributor

GeneGenie commented Jan 10, 2018

This doesn't seem to be fixed in 1.1.1 @protonate

screen shot 2018-01-10 at 13 14 20

The issues is that bidResponseCallback is triggering on auction end. And i'm done with my activities.
Then another bidResponse triggers, but nothing happens.

My setup is: 2 adunits, first with vertamediaBidAdapter, the second with appnexusBidAdapter.
Both adunits are instream video

Also tried to set timeout 2 seconds. But it did not help

UPD: it looks like, both adUnits have finished aucs, but both of them are fetching cache UUID. And when first finished the second one is still pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants