Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greenbids Analytics Adapter : fix double sampling #10091

Merged

Conversation

jbogp
Copy link
Contributor

@jbogp jbogp commented Jun 12, 2023

Type of change

  • Bugfix

Description of change

The sampling of the analytics module was done twice, once in the adapter and once in the generic AnalyticsAdapter.js file which is called by the module, leading the global sampling factor to be squared.

This PR removes the double sampling and only keeps the one from the generic AnalyticsAdapter.js file.

@ChrisHuie ChrisHuie changed the title GreenbidsAnalyticsAdapter: fix double sampling Greenbids Analytics Adapter : fix double sampling Jun 16, 2023
@ChrisHuie ChrisHuie self-assigned this Jun 16, 2023
@ChrisHuie ChrisHuie merged commit 8337584 into prebid:master Jun 16, 2023
github-ishara-chan-tung pushed a commit to ebuzzing/Prebid.js that referenced this pull request Jul 12, 2023
* fix greenbids analytics double sampling

* fix tests

* fix tests
musikele pushed a commit to rubicon-project/Prebid.js that referenced this pull request Aug 28, 2023
* fix greenbids analytics double sampling

* fix tests

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants