Yahoo Bid Adapter: Rebrand to Yahoo Advertising #10125
Conversation
| @@ -6,9 +6,9 @@ import { Renderer } from '../src/Renderer.js'; | |||
| import {hasPurpose1Consent} from '../src/utils/gpdr.js'; | |||
|
|
|||
| const INTEGRATION_METHOD = 'prebid.js'; | |||
| const BIDDER_CODE = 'yahoossp'; | |||
| const BIDDER_CODE = 'yahooAdvertising'; | |||
| const BIDDER_ALIASES = ['yahoossp'] | |||
There was a problem hiding this comment.
maybe yahoo as well?
You are welcome to change your bidder code and alias the old adapter, however, changing the filename is breaking because of the build instructions.
Line 170 in a35cda0
You'll have to wait for prebid 9 to do that. We just shipped Prebid 8 last week.
| @@ -6,9 +6,9 @@ import { Renderer } from '../src/Renderer.js'; | |||
| import {hasPurpose1Consent} from '../src/utils/gpdr.js'; | |||
|
|
|||
| const INTEGRATION_METHOD = 'prebid.js'; | |||
| const BIDDER_CODE = 'yahoossp'; | |||
| const BIDDER_CODE = 'yahooAdvertising'; | |||
There was a problem hiding this comment.
this will be quite annoying for publishers, as the key names in gam are restricted to 20 characters
There was a problem hiding this comment.
Yes, I thought this too. We will go back to product with this issue to get their thoughts on it
|
Hey @patmmccann - We've been instructed not to use just 'yahoo' as that is for the consumer side of the business. What we are doing now is to rename as 'yahooAds' for the bidder code. Documentation can retain the full brand name "Yahoo Advertising". We'll add 'yahooAdvertising' as an alias seeing as this bidder code was released in both PBS projects. |
|
lgtm, but your spec file changed names, can you make sure that filename isn't changed and we're good to go |
|
@patmmccann - All done. |
|
@patmmccann - Please hold off merging this just yet. There's another issue that may need resolving. |
|
@patmmccann - should be good to go now. Needed to make sure consent data was sent to our servers correctly in all cases and added an additional test. |
|
Hey @patmmccann - is there a chance that somebody could help us get this one over the line before the next release? |
|
@slimkrazy Thanks for the updates! |
slimkrazy
changed the title
* Yahoo bid adapter rebrand * Add deleted modules * Addressing PR feedback * Updated docs * Renamed spec file * Ensure consent data is pulled and sent correctly --------- Co-authored-by: slimkrazy <sam@slimkrazy.com>
* Yahoo bid adapter rebrand documentation * bidder code change as per comments in prebid/Prebid.js#10125 --------- Co-authored-by: slimkrazy <sam@slimkrazy.com>
* Yahoo bid adapter rebrand * Add deleted modules * Addressing PR feedback * Updated docs * Renamed spec file * Ensure consent data is pulled and sent correctly --------- Co-authored-by: slimkrazy <sam@slimkrazy.com>
* Yahoo bid adapter rebrand documentation * bidder code change as per comments in prebid/Prebid.js#10125 --------- Co-authored-by: slimkrazy <sam@slimkrazy.com>
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Rebrand to Yahoo Advertising. Bid adapter introduces a new
yahooAdvertisingbidder code, but continues to support the legacyyahoosspalias.Other information
Documentation site PR is here
@radubarbos, please cast your eye over this.