Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beOp Bid Adapter : addition of bpsegs attribute to request payload from ORTB2 object #10154

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions modules/beopBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,10 @@ export const spec = {
*/
buildRequests: function(validBidRequests, bidderRequest) {
const slots = validBidRequests.map(beOpRequestSlotsMaker);
const firstPartyData = bidderRequest.ortb2;
const psegs = (firstPartyData && firstPartyData.user && firstPartyData.user.ext && firstPartyData.user.ext.data) ? firstPartyData.user.ext.data.permutive : undefined;
const firstPartyData = bidderRequest.ortb2 || {};
const psegs = firstPartyData.user?.ext?.permutive || firstPartyData.user?.ext?.data?.permutive || [];
const userBpSegs = firstPartyData.user?.ext?.bpsegs || firstPartyData.user?.ext?.data?.bpsegs || [];
const siteBpSegs = firstPartyData.site?.ext?.bpsegs || firstPartyData.site?.ext?.data?.bpsegs || [];
const pageUrl = getPageUrl(bidderRequest.refererInfo, window);
const gdpr = bidderRequest.gdprConsent;
const firstSlot = slots[0];
Expand All @@ -61,6 +63,8 @@ export const spec = {
nid: firstSlot.nid,
nptnid: firstSlot.nptnid,
pid: firstSlot.pid,
psegs: psegs,
bpsegs: (userBpSegs.concat(siteBpSegs)).map(item => item.toString()),
url: pageUrl,
lang: (window.navigator.language || window.navigator.languages[0]),
kwds: keywords,
Expand All @@ -71,10 +75,6 @@ export const spec = {
tc_string: (gdpr && gdpr.gdprApplies) ? gdpr.consentString : null,
};

if (psegs) {
Object.assign(payloadObject, {psegs: psegs});
}

const payloadString = JSON.stringify(payloadObject);
return {
method: 'POST',
Expand Down
36 changes: 35 additions & 1 deletion modules/beopBidAdapter.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,14 @@
Module that connects to BeOp's demand sources

# Test Parameters

```
var adUnits = [
{
code: 'in-article',
mediaTypes: {
banner: {
sizes: [[1,1]],
sizes: [[1,1]],
}
},
bids: [
Expand All @@ -31,3 +32,36 @@ Module that connects to BeOp's demand sources
];
```

# Custom Bidder data

If you want to pass your first party data to BeOp, you can set your bidder `config.ortb2` object with

```json
{
"site": {
"ext": {
"bpsegs": ["Your", 1, "ST", "party", "data"],
"data": {
"bpsegs": ["Your", 1, "ST", "party", "data"]
}
}
},
"user": {
"ext": {
"bpsegs": ["Your", 1, "ST", "party", "data"],
"data": {
"bpsegs": ["Your", 1, "ST", "party", "data"]
}
}
}
}
```

You can choose the location between:

- `site.ext`
- `site.ext.data`
- `user.ext`
- `user.ext.data`

and our BidAdapter will be able to find them
20 changes: 18 additions & 2 deletions test/spec/modules/beopBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -130,15 +130,15 @@ describe('BeOp Bid Adapter tests', () => {
expect(payload.url).to.exist;
// check that the protocol is added correctly
expect(payload.url).to.equal('http://test.te');
expect(payload.psegs).to.not.exist;
});

it('should call the endpoint with psegs data if any', function () {
it('should call the endpoint with psegs and bpsegs (stringified) data if any or [] if none', function () {
let bidderRequest =
{
'ortb2': {
'user': {
'ext': {
'bpsegs': ['axed', 'axec', 1234],
'data': {
'permutive': [1234, 5678, 910]
}
Expand All @@ -154,6 +154,22 @@ describe('BeOp Bid Adapter tests', () => {
expect(payload.psegs).to.include(5678);
expect(payload.psegs).to.include(910);
expect(payload.psegs).to.not.include(1);
expect(payload.bpsegs).to.exist;
expect(payload.bpsegs).to.include('axed');
expect(payload.bpsegs).to.include('axec');
expect(payload.bpsegs).to.include('1234');

let bidderRequest2 =
{
'ortb2': {}
};

const request2 = spec.buildRequests(bidRequests, bidderRequest2);
const payload2 = JSON.parse(request2.data);
expect(payload2.psegs).to.exist;
expect(payload2.psegs).to.be.empty;
expect(payload2.bpsegs).to.exist;
expect(payload2.bpsegs).to.be.empty;
});

it('should not prepend the protocol in page url if already present', function () {
Expand Down