Relay Bid Adapter : Initial Release #10197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
@jcswart can you please pull in recent commits on master. Hopefully that fixes the circleci build issue |
|
@ChrisHuie All fixed up, thank you. |
|
Any news on this @mmoschovas or @ChrisHuie ? |
mmoschovas
reviewed
Aug 8, 2023
modules/relayBidAdapter.js
Outdated
| sync.url = syncUrl.toString(); | ||
| } | ||
| if (syncOptions.iframeEnabled && sync.type === 'iframe') { syncs.push(sync); } | ||
| if (syncOptions.pixelEnabled && sync.type === 'image') { syncs.push(sync); } |
There was a problem hiding this comment.
Can this be an else if? Is there any reason to potentially allow both if image and iframe are enabled
There was a problem hiding this comment.
This change has been implemented in the latest commit.
mmoschovas
approved these changes
Aug 16, 2023
jxdeveloper1
added a commit
to jxdeveloper1/Prebid.js
that referenced
this pull request
Aug 18, 2023
* master: (107 commits) Increment version to 8.11.0-pre Prebid 8.10.0 release add privacyIcon to not native asset list (prebid#10259) gppControl_usstates: activity controls for US state consent (prebid#10283) UserID: check for all consent (not just GDPR) to check if an ID needs refreshing (prebid#10286) fluct Bid Adapter: add user.data to bid requests (prebid#10318) Prebid Server adapter: improve cookie_sync tests, check GPP fields are populated (prebid#10362) fix: consolidate banner format array (prebid#10365) consentManagementGpp: support GPP 1.1 (prebid#10282) Relay Bid Adapter : Initial Release (prebid#10197) Yieldmo Bid Adapter : adding 4.x VAST protocol support (prebid#10363) Cadent Aperture MX Bid Adapter: support GPP and GPP Section Ids (prebid#10342) identityLinkSubmodule: add additional check on retrieving the envelope (prebid#10355) fluct Bid Adapter: add gpid to bid requests (prebid#10361) Increment version to 8.10.0-pre Prebid 8.9.0 release fledgeForGpt: consolidate publisher configuration (prebid#10360) ConcertBidAdapter: Add `browserLanguage` to request `meta` object (prebid#10356) GrowthCode Analytics: Updates/BugFixes (prebid#10339) Activity Controls GPP: invalidate covered = 0 in mspa (prebid#10354) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Email of adapter's maintainer: relay@kevel.co
Add the Relay Bid Adapter
Other information
Doc PR: prebid/prebid.github.io#4720