-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fledgeForGpt: provide bidfloor
in auction signals
#10393
Conversation
70dd03d
to
5c3f371
Compare
I did a small "live" test - made a bundle with fledgeForGpt and openxBidAdapter, faked an openx server response to inject some auctionSignals and intercepted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey all I am out starting today and will not be able to review this. Sorry I did not get to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking @laurb9 's review as second, thanks!
Hi Guys, Am just confused with the sentence written in description section "or (if there were no bids) the minimum required floor across all requests for the slot." If there is no contextual bids for particular fledge slot, my assumption is that bid floor value should be 0. So what is "the minimum required floor across all requests for the slot." How this is calculated. Bit confused on this. Can you elaborate it more on this with examples ? TIA, |
@pm-nitin-nimbalkar , the publisher sets a floor value that is passed to all bidders in the contextual-request and bidders are required to bid higher than the floor value. if partners do not return contextual bids then in this case the floor value set by the publisher will be passed in PA. |
Got it @pm-harshad-mane . Thanks. |
Type of change
Description of change
This adds two auction signals to fledge:
prebid.bidfloor
andprebid.bidfloorcur
.The
bidfloor
value is either the highest CPM that Prebid got for the slot, or (if there were no bids) the minimum required floor across all requests for the slot.Other information
Closes #10139