-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZetaGlobalSsp AnalyticsAdapter: provide zeta params through cache #10402
ZetaGlobalSsp AnalyticsAdapter: provide zeta params through cache #10402
Conversation
Pull master
11111111111# the commit.
Please add a unit test or two covering the change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asurovenko-zeta Please don't modify directly the args
param you pass to your handlers. Instead use a copy, this way it can be safely modified before to be sent.
ex:
function adRenderSucceededHandler(orginalArgs) {
const args = deepClone(originalArgs);
// ...
if (args.bid) {
// cleanup object
delete args.bid.metrics;
delete args.bid.ad;
// ...
}
// ...
sendEvent(eventType, args);
}
@osazos sorry for the delay in fix. Now fix has been pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Type of change