Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZetaGlobalSsp AnalyticsAdapter: provide zeta params through cache #10402

Merged

Conversation

asurovenko-zeta
Copy link
Contributor

Type of change

  • Feature

asurovenko-zeta and others added 30 commits March 24, 2021 14:47
@robertrmartinez
Copy link
Collaborator

@asurovenko-zeta

Please add a unit test or two covering the change

Copy link
Collaborator

@osazos osazos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asurovenko-zeta Please don't modify directly the args param you pass to your handlers. Instead use a copy, this way it can be safely modified before to be sent.

ex:

function adRenderSucceededHandler(orginalArgs) {
  const args = deepClone(originalArgs);
  // ...

  if (args.bid) {
    // cleanup object
    delete args.bid.metrics;
    delete args.bid.ad;
    // ...
  }
  // ...
   sendEvent(eventType, args);
}

@asurovenko-zeta
Copy link
Contributor Author

@osazos sorry for the delay in fix. Now fix has been pushed.

Copy link
Collaborator

@osazos osazos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@osazos osazos merged commit 85bb955 into prebid:master Sep 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants