-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lm_Kiviads Bid Adapter : initial adapter release #10415
Conversation
@KiviAds - would it be possible to change your |
…ver-side parameters
changed placement -> pid according to server-side parameters |
@lksharma Hi, could you please check this pr? Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KiviAds please see my comment below on the bidder alias.
pending resolution on alias unique name
modules/lm_kiviadsBidAdapter.js
Outdated
|
||
export const spec = { | ||
code: BIDDER_CODE, | ||
aliases: ['kivi', 'kiviads'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aliases should be unique for the first 6 characters. There is already another another adapter with a bidder code named: kiviads
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lksharma, thanks for the information. The mistake has been fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Type of change
Description of change
New prebid adapter to connect to kiviads.com demand source
Other information
Docs PR: prebid/prebid.github.io#4829