Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media Filter RTD Provider : initial modul release #10418

Merged
merged 9 commits into from
Nov 14, 2023
Merged

Media Filter RTD Provider : initial modul release #10418

merged 9 commits into from
Nov 14, 2023

Conversation

mcajlakovic
Copy link
Contributor

Type of change

  • Feature
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

Description of change

Added The Media Filter RTD Provider module

For more information about The Media Filter, please see https://mediatrust.com/how-we-help/media-filter

@ChrisHuie ChrisHuie changed the title Added The Media Filter RTD Provider module Media Filter RTD Provider : initial modul release Sep 13, 2023
@mcajlakovic
Copy link
Contributor Author

Is there something I can do to help push this PR forward? (not sure if this is blocked by me?)

spotxslagle
spotxslagle approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@spotxslagle spotxslagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment on something I didn't understand, but it works either way, so LGTM

mcajlakovic
mcajlakovic commented Oct 6, 2023
View reviewed changes
Copy link
Contributor Author

@mcajlakovic mcajlakovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and responded to comments

@mcajlakovic
Copy link
Contributor Author

Hi @ChrisHuie, is there something I can do to help push this PR forward? Are we missing anything on our end?

@mcajlakovic
Copy link
Contributor Author

@ChrisHuie LGTM, are there any next steps for release?

@spotxslagle
Copy link
Contributor

@patmmccann

@mcajlakovic
Copy link
Contributor Author

@patmmccann @ChrisHuie @spotxslagle

@patmmccann
Copy link
Collaborator

Needs changes to submodules.json

@mcajlakovic
Copy link
Contributor Author

Needs changes to submodules.json
Added, thank you!

mcajlakovic
mcajlakovic commented Nov 13, 2023
View reviewed changes
Copy link
Contributor Author

@mcajlakovic mcajlakovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated adloader.js and .submodules.json

@patmmccann patmmccann merged commit 9c6cd73 into prebid:master Nov 14, 2023
@mcajlakovic
Copy link
Contributor Author

Thank you for your help on getting this pr merged! @spotxslagle @patmmccann

@mcajlakovic mcajlakovic mentioned this pull request Dec 11, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patmmccann patmmccann patmmccann left review comments

@spotxslagle spotxslagle spotxslagle approved these changes

Assignees

@spotxslagle spotxslagle

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcajlakovic @spotxslagle @patmmccann @ChrisHuie