Yieldmo Bid Adapter : dont require params.video #10467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@patmmccann Not sure who to tag on this one, do you have a yieldmo contact who can take a look? |
|
yep; will reach out. Also @desidiver |
patmmccann
approved these changes
Sep 12, 2023
ChrisHuie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
The Yieldmo Bidder Docs show example configurations where video ortb data can be in either
mediaTypes.videoORparams.videoHowever it breaks if at least one params.video parameter is NOT there (not safe checking Object.keys)
Not sure if this is intended or not, but it was an easy fix so I updated it.