Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qortex RTD Provider: initial release #10480

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

shilohannese
Copy link
Contributor

@shilohannese shilohannese commented Sep 13, 2023

Type of change

Adds new RTD module

Description of change

Creates new RTD adapter

Module Name: Qortex RTD Provider
Module Type: RTD Provider
Maintainer: mannese@qortex.ai
realTimeData: {
                    auctionDelay: 1000,
                    dataProviders: [    
                        {
                            name: "qortex",
                            waitForIt: true,
                            params: {
                                groupId: 'banner',
                                videoContainer: 'my-video-container',
                                apiUrl: 'https://dev-demand.qortex.ai',
                                tagConfig: {
                                    videoContainer: 'my-video-container'
                                }
                            }

                        }
                    ]
                }

Other information

@mickannese
@rrochwick

@ChrisHuie ChrisHuie requested a review from Rothalack September 21, 2023 15:04
@ChrisHuie ChrisHuie changed the title Qortex RTD Provider: New Module Qortex RTD Provider: initial release Sep 21, 2023
@Rothalack
Copy link
Collaborator

Hey @mickannese you'll want to get a documentation page up on the prebid docs for this as well. Should end up here: https://docs.prebid.org/dev-docs/modules/index.html#vendor-specific-modules

You can get a PR up here: https://github.com/prebid/prebid.github.io/pulls

As for your code and testing, seems good to go! I'll let you know if I notice anything while you get that doc page up.

@shilohannese
Copy link
Contributor Author

Hi @Rothalack ,

Thank you very much for your help and guidance.

Here is the PR for the above mentioned documentation pages. I tested it locally and verified that our adapted shows in the proper position.

Please advise if you need anything else from me and have a great day.

Copy link
Collaborator

@Rothalack Rothalack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@Rothalack Rothalack merged commit 069d86b into prebid:master Sep 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants