-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PubmaticBidAdapter: Read and pass gpid from ortb2imp.ext in API call #10577
PubmaticBidAdapter: Read and pass gpid from ortb2imp.ext in API call #10577
Conversation
kicking off tests by committing as me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved pending circleci checks
seems like you are following your own fork in circleci and this prevents our tests from kicking off |
@patmmccann can you merge this ? |
@jlquaccia can we merge this ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and seems everything is passing now
…rebid#10577) * Pass gpid value from ortb2Imp.ext in translator call * Update pubmaticBidAdapter_spec.js kicking off tests by committing as me * Test * Test * Update pubmaticBidAdapter_spec.js * Commit to retrigger test cases --------- Co-authored-by: Patrick McCann <patmmccann@gmail.com>
Type of change
[x] Feature
Description of change
Reading the gpid from ortb2Imp.ext in adunits and pass it to translator call.