Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adnuntius Bid Adaptor: handle voidAuIds from server response #10646

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

antosarho
Copy link
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

  • invalid ad units are put into a voidAuIds array in the ad server response
  • this changeset stores those void ad units IDs into local storage and prevents calling to those same ad units.
  • also stores any values from metaData from the adserver response into local storage and sends it with subsequent requests
  • also some general refactoring

Other information

- invalid ad units are put into a voidAuIds array from
the ad server.
- this stores those ad units into local storage and prevents
calling to those ad units.
- also handles any values from metaData from the adserver response.
@ChrisHuie ChrisHuie changed the title Adnuntius Bid Adaptor: Handle voidAuIds from server response Adnuntius Bid Adaptor: handle voidAuIds from server response Oct 27, 2023
@ChrisHuie ChrisHuie requested a review from jlquaccia November 1, 2023 11:49
Copy link
Collaborator

@jlquaccia jlquaccia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisHuie ChrisHuie merged commit 7974ebc into prebid:master Nov 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants