-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doceree AdManager Bid Adapter: initial release #10684
Conversation
Please update the status of (#10684) pull request |
1 similar comment
Please update the status of (#10684) pull request |
added the link to docs PR |
@osazos please review to move the pull request for merge as we have urgent integration blocked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure regarding the file name of your adapter, it should be suffixed by "BidAdapter" (doc)
When testing your endpoint:
Your serverResponse.body
response is an array but your code is written to handle an object. Btw I didn't receive a "valid" response so perhaps it is an exepected format.
Also, it seems there is a mismatch regarding the requestId
in the request and the response:
// request
{
"userid": "7d26d8ca-233a-46c2-9d36-7c5d261e151d",
...
"requestId": "296180d3d4c11b",
}
// response
{
"response": [
{
"status": -1,
"adUnit": "DOC_7jm9j5eqkl0xvc5w",
"position": 0,
"adFormat": 0,
"userId": "7d26d8ca-233a-46c2-9d36-7c5d261e151d",
"bidRequestId": "0bdf4e05-38cf-43c1-8dca-8f1ed0a68e01-7sjmhc"
}
]
}
Which diplay the warning:
WARNING: Bidder docereeadmanager made bid for unknown request ID: undefined. Ignoring.
@osazos the changes you mentioned have been fixed. Kindly have a look on the updated code and make sure to use an correct adUnit (DOC-19-1) code for making a server call. Please let us know if we need to change anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information