Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharethrough adapter - Ensure cookies get sent in request headers #1069

Merged
merged 1 commit into from
Mar 23, 2017
Merged

Sharethrough adapter - Ensure cookies get sent in request headers #1069

merged 1 commit into from
Mar 23, 2017

Conversation

rizhang
Copy link
Contributor

@rizhang rizhang commented Mar 22, 2017

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other

Description of change

Add withCredentials: true to the AJAX call to make sure cookies get sent correctly

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Other information

Ensure cookies get sent in request headers
6ea3ebe 
* Add "withCredentials" to the AJAX call to make sure cookies get sent
* correctly
@rizhang rizhang changed the title Ensure cookies get sent in request headers Sharethrough adapter - Ensure cookies get sent in request headers Mar 22, 2017
@rizhang rizhang mentioned this pull request Mar 22, 2017
Merged
9 tasks
@mkendall07
Copy link
Member

LGTM.

@mkendall07 mkendall07 merged commit cb6cd4b into prebid:master Mar 23, 2017
vzhukovsky pushed a commit to aol/Prebid.js that referenced this pull request Apr 29, 2017
@rizhang @vzhukovsky
Ensure cookies get sent in request headers (prebid#1069)
b106d05 
* Add "withCredentials" to the AJAX call to make sure cookies get sent
* correctly
vzhukovsky added a commit to aol/Prebid.js that referenced this pull request May 6, 2017
@vzhukovsky
Merge pull request prebid#87 in AOLP_ADS_JS/prebid.js from contrib/sy…
921c22b 
…nc-with-aol-github to aolgithub-master

* commit '0c6c83cc2bfaeeafa9da967c90d83da4af58e7b3':
  Add change log entry.
  Renaming and fix missing semicolon.
  Update parsing script tag regexp.
  Refactoring. Replace stub bids objects, add additional case for rendering pixels.
  Refactoring. Replace test consts by methods.
  Create separate namespace for aol globals, add unit tests.
  Fix unit tests, remove unnecessary spaces.
  Implement render pixels only once feature.
  Add change log entry.
  Add reporting ID for analytics.
  Add Facebook Audience Network adapter
  fix specs
  update version
  fix jslint errors
  Change to using a closure for the callback from ajax to preserve bidObj
  Ensure cookies get sent in request headers (prebid#1069)
  Rz/ajax (#5) (prebid#1042)
@jchau87 jchau87 deleted the rz_pk/ajax_cookie branch June 21, 2018 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkendall07 mkendall07 mkendall07 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rizhang @mkendall07