-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DxKulture Bid Adapter : user syncs improvements #10738
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
aadcc5b
Initial implementation of kulturemedia bid adapter
dani-nova d2c56e7
Changing outstream to instream
dani-nova 74c1a14
Enriching md file with test examples
dani-nova 909476a
Changing nId to networkId
dani-nova 0679940
Cleaning up md file
dani-nova d3dfc6f
Merge remote-tracking branch 'upstream/master' into kulturemedia-adapter
dani-nova 6197325
Merge tag '8.8.0' into kulturemedia-adapter
c3ef5b7
Submitting rebranded dxkultureBidAdapter
610a2fe
Merge remote-tracking branch 'upstream/master' into kulturemedia-adapter
5d8d923
Merge pull request #1 from kokisolutions/kulturemedia-adapter
dani-nova ec87a41
Merge remote-tracking branch 'upstream/master'
22e2af8
Merge remote-tracking branch 'upstream/master'
spetkovic 883170c
Merge remote-tracking branch 'upstream/master'
8ab4104
Merge branch 'prebid:master' into master
spetkovic 4a2f7c8
dxkultureBidAdapter - Improve UserSyncs
spetkovic 4be33d6
Include gdpr/usp params in iframe usersync url
spetkovic b8c494a
Add gdpr/usp data to iframe usync urls
spetkovic 10769e7
Cleaning up testing html file
d2f9762
Adding outstream support
956dc58
Updating exchange endpoint
f0bad09
Resolve requests test
e5967b7
Resolving iframe/pixel priority when iframeEnabled/pixelEnabled
25f3b54
Improving userSync filtering condition
b45c5db
Prioritize iframe user syncing
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also dont think this is right which is why I suggested using an if/else for whichever should take priority. Not this suggests that if both pixel and iframe are enabled, neither condition will be true. Can you please update to an if/else giving one type priority over the other i.e.
if (syncOptions.iframeEnabled) {...} else if (syncOptions.pixelEnabled) {...}
which would give priority to iframe syncing or vice versa.