Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identityLink Id System : fix 3p call to always use tcf consent type 4 #10778

Merged

Conversation

mamatic
Copy link
Contributor

@mamatic mamatic commented Nov 30, 2023

Type of change

  • Bugfix

Description of change

identityLinkIdSystem - Liveramp - bug fix. Fix 3p call to always use tcf consent type 4.

We have removed logic where we were checking tcfPolicyVersion since back in a days we needed to know which version to send to our api because of backward compatibility. Since our back-end now only allows ct=4 parameter we need to change this, since tcfPolicyVersion been increased (now is 4) so now because of this logic, we always set ct parameter to 1, which is incorrect and causes error on http request.

@mamatic
Copy link
Contributor Author

mamatic commented Nov 30, 2023

Hi! @smenzer can you please take a look? Tnx

@ChrisHuie ChrisHuie requested a review from smenzer November 30, 2023 13:19
@ChrisHuie ChrisHuie changed the title identityLinkIdSystem - bug fix. Fix 3p call to always use tcf consent type 4 identityLink Id System : fix 3p call to always use tcf consent type 4 Nov 30, 2023
Copy link
Collaborator

@smenzer smenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smenzer smenzer merged commit 16133c5 into prebid:master Dec 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants