Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubicon Bid Adapter: Do not require API for video requests #10895

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Rubicon Bid Adapter: Do not require API for video requests #10895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions modules/rubiconBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1183,8 +1183,7 @@ export function hasValidVideoParams(bid) {
var requiredParams = {
mimes: arrayType,
protocols: arrayType,
linearity: numberType,
api: arrayType
linearity: numberType
}
// loop through each param and verify it has the correct
Object.keys(requiredParams).forEach(function(param) {
Expand Down
10 changes: 0 additions & 10 deletions test/spec/modules/rubiconBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2381,16 +2381,6 @@ describe('the rubicon adapter', function () {
bidderRequest = createVideoBidderRequest();
delete bidderRequest.bids[0].mediaTypes.video.linearity;
expect(spec.isBidRequestValid(bidderRequest.bids[0])).to.equal(false);

// change api to an string, no good
bidderRequest = createVideoBidderRequest();
bidderRequest.bids[0].mediaTypes.video.api = 'string';
expect(spec.isBidRequestValid(bidderRequest.bids[0])).to.equal(false);

// delete api, no good
bidderRequest = createVideoBidderRequest();
delete bidderRequest.bids[0].mediaTypes.video.api;
expect(spec.isBidRequestValid(bidderRequest.bids[0])).to.equal(false);
});

it('bid request is valid when video context is outstream', function () {
Expand Down