Sharethrough: Change to using a closure for the callback from ajax to preserve bidObj #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rizhang
changed the title
ndhimehta
assigned snapwich, mkendall07 and harpere and unassigned ndhimehta and snapwich
harpere
requested changes
Apr 20, 2017
src/adapters/sharethrough.js
Outdated
| bidResponse = JSON.parse(bidResponse); | ||
| const bidId = bidResponse.bidId; | ||
| const bidObj = utils.getBidRequest(bidId); | ||
| try { |
There was a problem hiding this comment.
this wasn't a change in this PR, but I'd suggest moving the try { above the JSON.parse() so any errors parsing the JSON are caught so the bids are added to the bidManager as errors.
| @@ -117,8 +108,8 @@ describe('sharethrough adapter', () => { | |||
| "stxUserId": "" | |||
| }; | |||
|
|
|||
| pbjs.strcallback(JSON.stringify(bidderReponse1)); | |||
| pbjs.strcallback(JSON.stringify(bidderReponse2)); | |||
| adapter.callback(bidderRequest.bids[0], JSON.stringify(bidderReponse1)); | |||
There was a problem hiding this comment.
rather than exposing the callback just for testing, it's preferred that you test using the sinon.fakeServer with a mock response and calling adapter.callBids(). You can see an example in here.
harpere
reviewed
Apr 20, 2017
src/adapters/sharethrough.js
Outdated
| @@ -39,10 +45,9 @@ var SharethroughAdapter = function SharethroughAdapter() { | |||
| return url; | |||
| } | |||
|
|
|||
| $$PREBID_GLOBAL$$.strcallback = function(bidResponse) { | |||
| function _strcallback(bidObj, bidResponse) { | |||
| bidResponse = JSON.parse(bidResponse); | |||
There was a problem hiding this comment.
I see there was another change (causing a conflict) where you wrapped this in a separate try/catch. I'd still recommend wrapping it in the try block below so that the bid is added to the bidManager (in your _handleInvalidBid() function) so it can still be tracked.
|
Made the changes! |
harpere
reviewed
Apr 27, 2017
src/adapters/sharethrough.js
Outdated
| @@ -102,6 +101,7 @@ var SharethroughAdapter = function SharethroughAdapter() { | |||
| return { | |||
| callBids: _callBids, | |||
| str : str, | |||
| callback: _strcallback | |||
There was a problem hiding this comment.
no need to expose callback any longer
|
thanks @rizhang! made one more minor comment. |
|
Made the change! |
harpere
approved these changes
May 3, 2017
mkendall07
approved these changes
May 4, 2017
outoftime
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
May 12, 2017
…built * 'master' of https://github.com/prebid/Prebid.js: inclusion of popular Nordic ad sizes to default size list (prebid#1168) pre release version bump Prebid 0.23.1 Release Add trafficSourceCode + test (prebid#1184) Clear cookie sync to prevent multiple calls (prebid#1181) change s2s adapter to filter out units with empty sizes array (prebid#1179) Sharethrough: Change to using a closure for the callback from ajax to preserve bidObj (prebid#1108) check array length when mapping sizes (prebid#1180) Bugfix/encoding url (prebid#1178)
vzhukovsky
added a commit
to aol/Prebid.js
that referenced
this pull request
May 25, 2017
…21.0 to aolgithub-master * commit '4d573b42c5fbbabf23fed48fa042b75a72dd16b2': (31 commits) Added prebidServer in aolPartnersIds.json. Added adapters in aolPartnersIds.json. Added changelog entry. Prebid 0.23.1 Release Add trafficSourceCode + test (prebid#1184) Clear cookie sync to prevent multiple calls (prebid#1181) change s2s adapter to filter out units with empty sizes array (prebid#1179) Sharethrough: Change to using a closure for the callback from ajax to preserve bidObj (prebid#1108) check array length when mapping sizes (prebid#1180) Bugfix/encoding url (prebid#1178) add lodash as dependency (prebid#1174) fix size mapping for s2s (prebid#1175) Improve footer styling (prebid#1171) Bugfix: internal bids requested overwritten (prebid#1173) pre-release version bump Prebid 0.23.0 Release Yieldbot adapter - multiple requestBids per pageview (prebid#1146) Widespace adapter validate size fix (prebid#1140) Audience Network: bid when at least one valid slot size (prebid#1148) Quantcast adaptor (prebid#1063) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Passing the bid request object inside the callback function, instead of relying on fetching it with a bid Id. When multiple auctions are ran, old bid requests will be deleted, which causes the adapter to error out.
rzhang@sharethrough.com
Other information