Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build system: fix standalone debugging & inclusion of node dependencies #11375

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

dgirardi
Copy link
Collaborator

Type of change

  • Bugfix

Description of change

Fixes #11365, as well as an issue where node dependencies that are only needed by some modules (e.g. live-connect) are included in core.

@dgirardi dgirardi marked this pull request as draft April 22, 2024 16:39
@dgirardi dgirardi force-pushed the fix-debugging-standalonde branch from c79fb61 to 148f4f7 Compare April 22, 2024 17:51
@dgirardi dgirardi marked this pull request as ready for review April 22, 2024 17:51
@jsnellbaker jsnellbaker requested a review from osazos April 22, 2024 19:12
Copy link
Collaborator

@osazos osazos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tested on the JSFiddle examples provided in the issue by using a fresh build

@ChrisHuie ChrisHuie merged commit bf6de06 into prebid:master Apr 30, 2024
4 checks passed
Ticki84 pushed a commit to criteo-forks/Prebid.js that referenced this pull request May 14, 2024
mefjush pushed a commit to adhese/Prebid.js that referenced this pull request May 21, 2024
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standalone Debugging Issue after v8.43.0
4 participants