Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yahoo Bid Adapter: adding plcmt param support #11569

Merged
merged 24 commits into from
May 29, 2024
Merged

Yahoo Bid Adapter: adding plcmt param support #11569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
d6968e0
change
DeepthiNeeladri Jan 17, 2024
2a50350
removing global filtet
Jun 27, 2019
64a9486
reverting page
Jun 27, 2019
aa94373
message
Jul 2, 2019
d8462f9
adapter change
Jul 3, 2019
83872f1
remove space
Jul 3, 2019
51e7649
renderer exist case
Jul 4, 2019
2add581
reverting package-lock.json
Jul 9, 2019
c066d6a
adding schain object
Aug 2, 2019
2af528e
adding tagid
Aug 7, 2019
996cc44
syntaxx error fix
Aug 7, 2019
e60dd55
video.html
Aug 7, 2019
3ea1cb3
space trailing
Aug 7, 2019
9960409
space
Aug 7, 2019
b27e0e4
tagid
Aug 7, 2019
31001d8
inventoryId and placement
Aug 14, 2019
daf8b82
rewarded video
Sep 3, 2019
f73164b
comment
Dec 19, 2019
a68b39e
update maintainer email address
Jan 17, 2024
48e9579
Merge remote-tracking branch 'upstream/master'
DeepthiNeeladri Apr 24, 2024
c687e6c
Merge remote-tracking branch 'upstream/master'
DeepthiNeeladri May 20, 2024
a6e97f7
rename to yahooads
DeepthiNeeladri May 21, 2024
041772c
plcmt
DeepthiNeeladri May 26, 2024
d794dac
Merge branch '9.0' into Rename-bid-adapter-module-for-PB9
DeepthiNeeladri May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/yahooAdsBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,7 @@ function appendImpObject(bid, openRtbObject) {
pos: deepAccess(bid, 'params.bidOverride.imp.video.pos') || bid.mediaTypes.video.pos || undefined,
playbackmethod: deepAccess(bid, 'params.bidOverride.imp.video.playbackmethod') || bid.mediaTypes.video.playbackmethod || undefined,
placement: deepAccess(bid, 'params.bidOverride.imp.video.placement') || bid.mediaTypes.video.placement || undefined,
plcmt: deepAccess(bid, 'params.bidOverride.imp.video.plcmt') || bid.mediaTypes.video.plcmt || undefined,
linearity: deepAccess(bid, 'params.bidOverride.imp.video.linearity') || bid.mediaTypes.video.linearity || 1,
protocols: deepAccess(bid, 'params.bidOverride.imp.video.protocols') || bid.mediaTypes.video.protocols || [2, 5],
startdelay: deepAccess(bid, 'params.bidOverride.imp.video.startdelay') || bid.mediaTypes.video.startdelay || 0,
Expand Down
2 changes: 2 additions & 0 deletions modules/yahooAdsBidAdapter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,6 +581,7 @@ Currently the bidOverride object only accepts the following:
* pos
* playbackmethod
* placement
* plcmt
* linearity
* protocols
* rewarded
Expand Down Expand Up @@ -619,6 +620,7 @@ const adUnits = [{
pos: 1,
playbackmethod: 0,
placement: 1,
plcmt: 1,
linearity: 1,
protocols: [2,5],
startdelay: 0,
Expand Down
19 changes: 13 additions & 6 deletions test/spec/modules/yahooAdsBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1169,7 +1169,8 @@ describe('Yahoo Advertising Bid Adapter:', () => {
pos: undefined,
playbackmethod: undefined,
rewarded: undefined,
placement: undefined
placement: undefined,
plcmt: undefined
});
});

Expand Down Expand Up @@ -1201,7 +1202,8 @@ describe('Yahoo Advertising Bid Adapter:', () => {
pos: undefined,
playbackmethod: undefined,
rewarded: undefined,
placement: undefined
placement: undefined,
plcmt: undefined
});
});
});
Expand Down Expand Up @@ -1298,7 +1300,8 @@ describe('Yahoo Advertising Bid Adapter:', () => {
pos: undefined,
playbackmethod: undefined,
rewarded: undefined,
placement: undefined
placement: undefined,
plcmt: undefined
});
});
});
Expand Down Expand Up @@ -1351,7 +1354,8 @@ describe('Yahoo Advertising Bid Adapter:', () => {
pos: undefined,
playbackmethod: undefined,
rewarded: undefined,
placement: undefined
placement: undefined,
plcmt: undefined
});
});
});
Expand Down Expand Up @@ -1381,7 +1385,8 @@ describe('Yahoo Advertising Bid Adapter:', () => {
pos: 123456,
playbackmethod: 1,
rewarded: 1,
placement: 1
placement: 1,
plcmt: 1
}
}
}
Expand Down Expand Up @@ -1410,7 +1415,8 @@ describe('Yahoo Advertising Bid Adapter:', () => {
delivery: 1,
pos: 123456,
playbackmethod: 1,
placement: 1
placement: 1,
plcmt: 1
}
const validBidRequests = [bidRequest];
bidderRequest.bids = validBidRequests;
Expand All @@ -1430,6 +1436,7 @@ describe('Yahoo Advertising Bid Adapter:', () => {
pos: 123456,
playbackmethod: 1,
placement: 1,
plcmt: 1,
rewarded: undefined
});
});
Expand Down