Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consentManagementTcf: add flag to set dsarequired #11824

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

dgirardi
Copy link
Collaborator

Type of change

  • Feature

Description of change

Closes #10688

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

@patmmccann
Copy link
Collaborator

@dgirardi shall we eat our own dog food?

@patmmccann
Copy link
Collaborator

🤩

@patmmccann patmmccann self-assigned this Jun 18, 2024
@patmmccann patmmccann added needs docs needs 2nd review Core module updates require two approvals from the core team labels Jun 18, 2024
@patmmccann patmmccann assigned mkomorski and unassigned patmmccann Jun 19, 2024
@patmmccann patmmccann merged commit d8937d7 into prebid:master Jun 25, 2024
5 checks passed
@patmmccann patmmccann added feature and removed needs 2nd review Core module updates require two approvals from the core team labels Jun 26, 2024
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this pull request Jul 18, 2024
* consentManagementTcf: add flag to set dsarequired

* Fix duplication
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consent Management module: enrich requests on regs.ext.dsa
3 participants