LiveIntent User ID Module: Eliminating live-connect NPM Dependency #12167
Conversation
Co-authored-by: Viktor Dreiling <34981284+3link@users.noreply.github.com>
|
Tread carefully! This PR adds 8 linter errors (possibly disabled through directives):
|
|
Tread carefully! This PR adds 6 linter errors (possibly disabled through directives):
|
|
Tread carefully! This PR adds 5 linter errors (possibly disabled through directives):
|
|
Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):
|
|
Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):
|
|
@jlquaccia I have a question about possible ways to extend our user id module that depends on the external LiveConnect. Would it be possible to extend the module configuration such that a URL can be provided from which to download the LiveConnect script and the user id module would then embed this script on the page? If no such URL is provided in the configuration, nothing will be embedded. That would make the switch for our customers smoother as they will just need to add an additional config to our user id module and it will automatically deploy the script. |
Overall, I think the changes on this PR seem fine to me. In terms of allowing a URL to be provided via module configuration, I'm not sure if that is a direction that Prebid would like to go in since it seems it could open some security related scenarios. @ncolletti @patmmccann what are your thoughts |
Just to provide more context here: our customers would now be required to place our LiveConnect script on their domains in order for our user ID sub-module to work. We have customers with thousands of domains and it would make upgrading to the newer Prebid/LiveIntent sub-module version much easier for them if instead of setting up LiveConnect on each of their pages manually, they could configure their URL for the LiveConnect script directly in our user ID module. |
|
@3link As far as I'm aware Prebid has been upfront about not allowing external code to be loaded other than from RTD Modules where a contract/registration to acknowledge the contents of the JS by the publisher is signed prior. While cumbersome, I think this configuration is preferred by Prebid. Somewhat recent guidance on this topic: #9570 Any case, I don't know if a change should happen in this iteration of your adapter. It's best to bring this up to the Identity PMC group for further discussion |
@ncolletti That makes sense. Thank you for the link! I think it makes sense to keep these two topics separate and merge this version of the module as is for now. |
|
@jlquaccia looks good to me, will let you give a final sign off and merge |
|
@ncolletti yep, looks good to me too. Merging now.. |
| import { LiveConnect } from 'live-connect-js'; // eslint-disable-line prebid/validate-imports | ||
| import { getStorageManager } from '../../src/storageManager.js'; | ||
| import { MODULE_TYPE_UID } from '../../src/activities/modules.js'; | ||
| import { DEFAULT_AJAX_TIMEOUT, MODULE_NAME, composeIdObject, eids, DEFAULT_DELAY, GVLID, PRIMARY_IDS, parseRequestedAttributes } from './shared.js' |
There was a problem hiding this comment.
Hi. You are importing the DEFAULT_DELAY const but it does not exist.
There was a problem hiding this comment.
@s-solodovnikov Good catch! Thank you notifying me. Will fix.
Type of change
Description of change
Allows to use the LiveIntent user ID module with an instance of LiveConnect v3 present on the page instead of inlining the LiveConnect NPM module into the user ID module as described here: #11541.
The goal is to support both
standard/minimalmode as well as theexternalmode during the migration phase. Once all our customers have migrated away from usingstandard/minimalmode, we will deprecate this mode and delete the LiveConnect NPM module dependency from Prebid together with all the code that depends on it. That would include moving the code fromlibraries/liveIntentIdback intomodules/liveintentIdSystemas we would not need to differentiate between two module implementations.Other information