Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Bidder: dexerto #12182

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

New Bidder: dexerto #12182

wants to merge 3 commits into from

Conversation

pranavsheth
Copy link

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

@pranavsheth
Copy link
Author

@ncolletti - if everything is fine, then can you pl merge with main branch?

@ncolletti
Copy link
Contributor

@pranavsheth sorry, I was not available last week. I should have time this week to review

libraries/audUtils/bidderUtils.js Outdated Show resolved Hide resolved
libraries/audUtils/bidderUtils.js Outdated Show resolved Hide resolved
libraries/audUtils/bidderUtils.js Outdated Show resolved Hide resolved
libraries/audUtils/bidderUtils.js Outdated Show resolved Hide resolved
libraries/audUtils/bidderUtils.js Outdated Show resolved Hide resolved
modules/dexertoBidAdapter.md Outdated Show resolved Hide resolved
@pranavsheth
Copy link
Author

@ncolletti we have made the requested changes.

@pranavsheth
Copy link
Author

pranavsheth commented Sep 9, 2024

Hi @ncolletti we have made those changes as requested by you. if everything is fine, then can you pl merge with main branch.

modules/dexertoBidAdapter.md Outdated Show resolved Hide resolved
libraries/audUtils/bidderUtils.js Show resolved Hide resolved
@pranavsheth
Copy link
Author

@ncolletti removed domain from both PR's.

@pranavsheth
Copy link
Author

Hello @ncolletti,

we have made those changes as requested by you. if everything is fine, then can you pl merge with main branch.

{
bidder: 'dexerto',
params: {
placement_id: 110003, // Required parameter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these params should return a response 100% of requests for testing. please update your endpoint to return bids that your adapter accepts and processes

Copy link
Author

@pranavsheth pranavsheth Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ncolletti
This is an expected behaviour, we have frequency cap running. Please refresh multiple times as we send 204 some times.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pranavsheth sorry, after many refreshes I only see 204 or empty 200 responses. this will need to be updated to params that will return valid bids on all requests for prebid testing.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ncolletti we made appropriate changes, now you will see ads for each requests. Bidder will send response 200 all the times.
Please verify earliest,.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pranavsheth Sorry, I am not seeing this when testing the placement_id you provided in your markdown file. I am seeing your bidUtils intepretResponse function error when reading your no bid 204 response, please fix this and return a bid in your 200 response:
Screenshot 2024-09-20 at 11 33 05 AM
Screenshot 2024-09-20 at 11 33 22 AM

Copy link
Author

@pranavsheth pranavsheth Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @ncolletti
Can you try now and can you also provide me your request which is being forwarded to bidder endpoint.
Also can u tell your ip address from which you are sending request and what tool are you using.

@pranavsheth
Copy link
Author

Hello @ncolletti
If everything is fine, then can you pl merge with main branch.

@pranavsheth
Copy link
Author

Hello @ncolletti
I am hoping the test has been passed. If this can be merged to the main branch?
thanks

@pranavsheth
Copy link
Author

Hello @ncolletti

Did u got the chance to test it out again, let me know if you find any issues.

thanks

@pranavsheth
Copy link
Author

Hi @ncolletti

Hoping for a quick resolution for this, our end point is working and responding with an ad. We are wondering is there any networking issue like https or any specfic tools you may be using to test this. This is the url were ads are serving https://admin.audiencelogy.net/prebid/prebid.html is this working for you?

From your testing environmnet, can you send the exact request you are sending to our endpoint - https://rtb.dexerto.media/hb/dexerto (note- this end point returns a value 1 when checked in browser, which is the health check code)

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants