-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Bidder: dexerto #12182
base: master
Are you sure you want to change the base?
New Bidder: dexerto #12182
Conversation
@ncolletti - if everything is fine, then can you pl merge with main branch? |
@pranavsheth sorry, I was not available last week. I should have time this week to review |
@ncolletti we have made the requested changes. |
Hi @ncolletti we have made those changes as requested by you. if everything is fine, then can you pl merge with main branch. |
@ncolletti removed domain from both PR's. |
Hello @ncolletti, we have made those changes as requested by you. if everything is fine, then can you pl merge with main branch. |
{ | ||
bidder: 'dexerto', | ||
params: { | ||
placement_id: 110003, // Required parameter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these params should return a response 100% of requests for testing. please update your endpoint to return bids that your adapter accepts and processes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ncolletti
This is an expected behaviour, we have frequency cap running. Please refresh multiple times as we send 204 some times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pranavsheth sorry, after many refreshes I only see 204 or empty 200 responses. this will need to be updated to params that will return valid bids on all requests for prebid testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ncolletti we made appropriate changes, now you will see ads for each requests. Bidder will send response 200 all the times.
Please verify earliest,.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pranavsheth Sorry, I am not seeing this when testing the placement_id you provided in your markdown file. I am seeing your bidUtils intepretResponse function error when reading your no bid 204 response, please fix this and return a bid in your 200 response:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @ncolletti
Can you try now and can you also provide me your request which is being forwarded to bidder endpoint.
Also can u tell your ip address from which you are sending request and what tool are you using.
Hello @ncolletti |
Hello @ncolletti |
Hello @ncolletti Did u got the chance to test it out again, let me know if you find any issues. thanks |
Hi @ncolletti Hoping for a quick resolution for this, our end point is working and responding with an ad. We are wondering is there any networking issue like https or any specfic tools you may be using to test this. This is the url were ads are serving https://admin.audiencelogy.net/prebid/prebid.html is this working for you? From your testing environmnet, can you send the exact request you are sending to our endpoint - https://rtb.dexerto.media/hb/dexerto (note- this end point returns a value 1 when checked in browser, which is the health check code) Thank you. |
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information