Core: Adding useBaseGvlid to aliasBidAdapter #12247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkomorski
changed the title
dgirardi
reviewed
Sep 16, 2024
| @@ -1630,6 +1630,16 @@ describe('adapterManager tests', function () { | |||
| expect(adapterManager.videoAdapters).to.include(alias); | |||
| } | |||
| }); | |||
|
|
|||
| it('should use gvlid of original adapter when option set', () => { | |||
| const mediaType = FEATURES.VIDEO ? 'video' : 'banner' | |||
There was a problem hiding this comment.
This doesn't seem necessary - you're not testing anything about media types.
src/adapterManager.js
Outdated
| let gvlid = options && options.gvlid; | ||
| if (spec.gvlid != null && gvlid == null) { | ||
| const gvlid = useBaseGvlid ? spec.gvlid : options?.gvlid; | ||
| if (!useBaseGvlid && spec.gvlid != null && options?.gvlid == null) { |
There was a problem hiding this comment.
Suggested change
| if (!useBaseGvlid && spec.gvlid != null && options?.gvlid == null) { | |
| if (gvlid == null && spec.gvlid != null) { |
8 tasks
dgirardi
approved these changes
Sep 17, 2024
ChrisHuie
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information
#10759