Core: Sync between ortb2Imp and mediaTypes #12423
Open
+439
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkomorski
changed the title
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
mkomorski
force-pushed
the
user/mkomorski/12166-mediatypes-ortb2
branch
from
f0262b1
to
b1b013e
Compare
mkomorski
force-pushed
the
user/mkomorski/12166-mediatypes-ortb2
branch
from
bee9b4a
to
6bf0566
Compare
mkomorski
force-pushed
the
user/mkomorski/12166-mediatypes-ortb2
branch
from
6bf0566
to
2ae9306
Compare
dgirardi
reviewed
Nov 19, 2024
src/prebid.js
Outdated
Comment on lines
116
to
118
| 'video': ORTB_VIDEO_PARAMS, | ||
| 'native': ORTB_NATIVE_PARAMS, | ||
| 'banner': ORTB_BANNER_PARAMS |
There was a problem hiding this comment.
these should be broken out with feature tags (FEATURE.NATIVE & FEATURE.VIDEO)
src/prebid.js
Outdated
| const battr = ortb2Imp[mediaType]?.battr || mediaTypes[mediaType]?.battr; | ||
| const fields = { | ||
| 'video': ORTB_VIDEO_PARAMS, | ||
| 'native': ORTB_NATIVE_PARAMS, |
There was a problem hiding this comment.
I would not deal with native here, the mediaType and imp fields have no overlap, and it gets complicated with mediaType.native.ortb.
dgirardi
reviewed
Nov 21, 2024
| } | ||
|
|
||
| const battr = ortb2Imp[mediaType]?.battr || mediaTypes[mediaType]?.battr; | ||
| const fields = { | ||
| [VIDEO]: ORTB_VIDEO_PARAMS, |
There was a problem hiding this comment.
Suggested change
| [VIDEO]: ORTB_VIDEO_PARAMS, | |
| [VIDEO]: FEATURES.VIDEO && ORTB_VIDEO_PARAMS |
| maxduration: 'omitted_value' | ||
| } | ||
| }, | ||
| ortb2Imp: {} |
There was a problem hiding this comment.
Suggested change
| ortb2Imp: {} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information
#12166