Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Module: Local cache for video bids #12502

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mkomorski
Copy link
Collaborator

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

#11393

@patmmccann
Copy link
Collaborator

patmmccann commented Nov 26, 2024

@mkomorski how do the blobs go away over time? Is there a risk of running out of storage?

@mkomorski
Copy link
Collaborator Author

mkomorski commented Nov 26, 2024

@mkomorski how do the blobs go away over time? Is there a risk of running out of storage?

@patmmccann They just get cleaned up when document scope is gone, so they will live till the user close the browser/tab. I don't think there is a limited memory pool dedicated for blobs so it's most likely matter of browser memory. But it can actually be a bit more efficient to also explicitly revoke not needed ones (lost bids) when auction ends up. good call

@patmmccann
Copy link
Collaborator

Maybe when the ttl expires instead? They might enter the cache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants