-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
symitriDapRtdProvider - Enable X2 Tokenize endpoint #12636
base: master
Are you sure you want to change the base?
symitriDapRtdProvider - Enable X2 Tokenize endpoint #12636
Conversation
ci/circleci Build failure seems unrelated to our changes. Additionally other PRs seem to be suffering from the same failure?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpalladino84 please cover these changes with unit tests
your test failures were a timeout on browserstack edge, all the other browsers passed
7df31f5
to
3141a44
Compare
@patmmccann Thanks for confirming. Tests have been added. |
3141a44
to
52edc8b
Compare
); | ||
let request = server.requests[0]; | ||
request.respond(400, responseHeader, JSON.stringify('error')); | ||
expect(submoduleCallback).to.equal(undefined); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're just testing for undefined callback; it seems your pr shows changing the endpoint, you should test if changing the config successfully changes the endpoint destination
Type of change
Description of change
We are making our new X2 Tokenize endpoint available for clients that so choose to use it. This change allows clients to alter the api_version in their config to use either
x1
orx2
. The X1 Tokenize endpoint is still available for clients that do not wish to, or need to switch.Additionally all clients will still use our X1 Membership endpoint regardless of the api_version setting.