Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symitriDapRtdProvider - Enable X2 Tokenize endpoint #12636

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jpalladino84
Copy link
Contributor

Type of change

  • Feature

Description of change

We are making our new X2 Tokenize endpoint available for clients that so choose to use it. This change allows clients to alter the api_version in their config to use either x1 or x2. The X1 Tokenize endpoint is still available for clients that do not wish to, or need to switch.

Additionally all clients will still use our X1 Membership endpoint regardless of the api_version setting.

@jpalladino84
Copy link
Contributor Author

ci/circleci Build failure seems unrelated to our changes. Additionally other PRs seem to be suffering from the same failure?

[21:03:22] 'test-only' errored after 30 min
[21:03:22] Error: Karma tests failed with exit code 1
    at ChildProcess.<anonymous> (/home/circleci/Prebid.js/gulpfile.js:418:12)
    at ChildProcess.emit (node:events:519:28)
    at ChildProcess.emit (node:domain:551:15)
    at ChildProcess._handle.onexit (node:internal/child_process:294:12)
    at Process.callbackTrampoline (node:internal/async_hooks:130:17)
[21:03:22] 'test' errored after 35 min

Exited with code exit status 1```

Copy link
Collaborator

@patmmccann patmmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpalladino84 please cover these changes with unit tests

your test failures were a timeout on browserstack edge, all the other browsers passed

@jpalladino84 jpalladino84 force-pushed the symitriDapRtdProvider-X2-Tokenize-endpoint branch from 7df31f5 to 3141a44 Compare January 9, 2025 23:20
@jpalladino84
Copy link
Contributor Author

@patmmccann Thanks for confirming.

Tests have been added.

@jpalladino84 jpalladino84 force-pushed the symitriDapRtdProvider-X2-Tokenize-endpoint branch from 3141a44 to 52edc8b Compare January 9, 2025 23:37
);
let request = server.requests[0];
request.respond(400, responseHeader, JSON.stringify('error'));
expect(submoduleCallback).to.equal(undefined);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're just testing for undefined callback; it seems your pr shows changing the endpoint, you should test if changing the config successfully changes the endpoint destination

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants