Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify 'featureforward' adapter to be an indepandant adapter #1288

Merged
merged 9 commits into from
Aug 22, 2017
Merged

modify 'featureforward' adapter to be an indepandant adapter #1288

merged 9 commits into from
Aug 22, 2017

Conversation

FeatureForwardDev
Copy link
Contributor

@FeatureForwardDev FeatureForwardDev commented Jun 12, 2017 •
edited
Loading

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

Other information

@matthewlane matthewlane self-assigned this Jun 15, 2017
matthewlane
matthewlane previously approved these changes Jun 20, 2017
View reviewed changes
Copy link
Collaborator

@matthewlane matthewlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass and was able to get bid responses from a test page using

{
  bidder: 'featureforward',
  params: {
    pubId: '001',
    siteId: '111',
    placementId: '1',
  }
}

LGTM

@matthewlane
Copy link
Collaborator

matthewlane commented Jul 11, 2017 •
edited
Loading

@tlvmedia Please resolve conflicts, thanks

@snapwich
Copy link
Collaborator

this code needs to be updated to use the new module format

@dbemiller dbemiller removed the LGTM label Jul 26, 2017
@mkendall07
Copy link
Member

@tlvmedia Please move your adapter code into /modules directory. Thanks

@mkendall07 mkendall07 merged commit daf0a24 into prebid:master Aug 22, 2017
outoftime pushed a commit to Genius/Prebid.js that referenced this pull request Aug 24, 2017
Merge branch 'master' of https://github.com/prebid/Prebid.js into pre…
3d8e268 
…built

* 'master' of https://github.com/prebid/Prebid.js: (83 commits)
  feat(strAdapt): check if tagJS is already present (prebid#1500)
  Updated karma-mocha, and simplified the test framework for runs which dont include --watch. (prebid#1520)
  Revert "drop specific code for index adapter (prebid#1487)" (prebid#1529)
  Override default asset params when set on ad unit (prebid#1524)
  Adding new kv to xhb Adapter (prebid#1513)
  removing for...of loops because IE cannot handle them properly (prebid#1523)
  Increment pre version
  Prebid 0.27.0 Release
  Move unit test file to appropriate location (prebid#1516)
  Support 'cta' native asset (prebid#1505)
  Add adapter parameter types (prebid#1504)
  Register bid adapter (prebid#1514)
  Match port when testing legacy browser (prebid#1511)
  modify 'featureforward' adapter to be an indepandant adapter (prebid#1288)
  Feature/s2s client side fallback (prebid#1485)
  Make bid.vastUrl use the cache URL if the bid didnt already have one. (prebid#1506)
  OpenX Adapter Update: (prebid#1438)
  Add session id feature for roxot analytics adapter (prebid#1498)
  Update platformioBidAdapter (prebid#1493)
  Adding VAST Payload support for video bids (prebid#1407)
  ...
ptomasroos pushed a commit to happypancake/Prebid.js that referenced this pull request Aug 25, 2017
@FeatureForwardDev @ptomasroos
modify 'featureforward' adapter to be an indepandant adapter (prebid#…
4e4671a 
…1288)

* changing featureforward to be an independant adapter

* initial version of featureforward adapter

* featureforward adapter auto test

* small fixes 1

* fixes 2

* fixes 3

* Create featureforwardBidAdapter.js

*  file is not needed anymore
philipwatson pushed a commit to mbrtargeting/Prebid.js that referenced this pull request Sep 18, 2017
@FeatureForwardDev @philipwatson
modify 'featureforward' adapter to be an indepandant adapter (prebid#…
2fe7e21 
…1288)

* changing featureforward to be an independant adapter

* initial version of featureforward adapter

* featureforward adapter auto test

* small fixes 1

* fixes 2

* fixes 3

* Create featureforwardBidAdapter.js

*  file is not needed anymore
jbAdyoulike pushed a commit to jbAdyoulike/Prebid.js that referenced this pull request Sep 21, 2017
@FeatureForwardDev @jbAdyoulike
modify 'featureforward' adapter to be an indepandant adapter (prebid#…
09216d0 
…1288)

* changing featureforward to be an independant adapter

* initial version of featureforward adapter

* featureforward adapter auto test

* small fixes 1

* fixes 2

* fixes 3

* Create featureforwardBidAdapter.js

*  file is not needed anymore
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@FeatureForwardDev @dluxemburg
modify 'featureforward' adapter to be an indepandant adapter (prebid#…
0e595bf 
…1288)

* changing featureforward to be an independant adapter

* initial version of featureforward adapter

* featureforward adapter auto test

* small fixes 1

* fixes 2

* fixes 3

* Create featureforwardBidAdapter.js

*  file is not needed anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkendall07 mkendall07 mkendall07 approved these changes

@matthewlane matthewlane matthewlane left review comments

Assignees

@matthewlane matthewlane

Labels
needs update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FeatureForwardDev @matthewlane @snapwich @mkendall07 @dbemiller