-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spotx video Adapter #1326
Spotx video Adapter #1326
Conversation
- If passed an id set the slot and video_slot element when initializing the directsdk
Addressing code review comments for spotx adapter. Add spotx_spec.js file for unit tests. Increase test coverage Add check for directSDK slot and video_slot - If passed an id set the slot and video_slot element when initializing the directsdk Undo bracket notation change
…rebid.js into spotx-adapter-eric
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@npeceniak
I am getting error "adloader.js:loadScript: Error executing callback" Error: Invalid options: 'video_slot' is required.
when testing with hello_world test page.
Also left some minor comments.
// Load the SpotX Direct AdOS SDK onto the page | ||
function loadDSDK() | ||
{ | ||
var channelId = bidReq.params.video.channel_id; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a function to validate your params.
modules/spotxBidAdapter.js
Outdated
|
||
bid.cpm = KVP_Object.spotx_bid; | ||
bid.vastUrl = url; | ||
bid.descriptionUrl = url; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can remove descriptionUrl
. vastUrl
will suffice
- Added parameter validation function - removed descriptionUrl
I have pushed a new commit addressing your two comments. The error you were getting on the hello_world test page is likely because our adapter requires the slot and video_slot to exist on the page. Something like the following would need to be added.
I created a test page for use while I was developing the adapter but I did not want to include that test page in the pull request as it was really just for testing. I have attached my working test page here which should be using the same bid parameters as the test parameters above. |
This reverts commit 579cf9a.
Type of change
Description of change
Add Spotx video bidder adapter
Be sure to test the integration with your adserver using the Hello World sample page.
npeceniak@spotx.tv
Other information