Add s2s and user sync features to roxot analytics adapter #1337
Conversation
Feature/user sync
Feature/s2s tracking
|
Nice! I'm adding a Prebid.js/src/adaptermanager.js Line 110 in 6f06a9e |
|
|
|
When can we expect #1330 to be merged to the master? |
|
@sergey-roxot |
This reverts commit 89a44e3.
|
We had removed s2s feature and now using source argument. Our pull request includes only user sync feature now. |
|
When do you plan to review our pull request? |
| (result) => utils.logInfo('Event ' + eventType + ' sent ' + sendDataType + ' to roxot prebid analytic with result' + result), | ||
| JSON.stringify(data) | ||
| ); | ||
| let xhr = new XMLHttpRequest(); |
There was a problem hiding this comment.
what's the reason you can't use ajax function?
There was a problem hiding this comment.
FYI, you can turn on cookies:
ajax(ENDPOINT, handleResponse, payload, {
contentType: 'text/plain',
withCredentials: true
});
There was a problem hiding this comment.
Depending on the publisher's setup, some requests are processed longer than others. But when it takes more than 3 sec to record all events, requests are canceled by the recently implemented timeout to ajax requests. As a result, we may lose some of the data. While optimizing our system and speeding up data processing, we want to make sure nothing is lost.
There was a problem hiding this comment.
Fair point. We should allow analytics adapters to override the timeout. For now this is fine.
)" This reverts commit b54004d.
* add roxot adapter * update roxot analytics system * remove unused test * remove unused import * update code after review * Added s2s tracking * Add user sync * Empty s2sConfig case handling added * Removed s2s * Add s2s bidder code setters * Revert "Add s2s bidder code setters" This reverts commit 89a44e3. * Revert "Removed s2s" This reverts commit 929707f. * Revert "Empty s2sConfig case handling added" This reverts commit 2f55e24. * Revert s2s * Removed user sync feature via iframe * Add ajax withCredentials option * Add xhr withCredentials
* add roxot adapter * update roxot analytics system * remove unused test * remove unused import * update code after review * Added s2s tracking * Add user sync * Empty s2sConfig case handling added * Removed s2s * Add s2s bidder code setters * Revert "Add s2s bidder code setters" This reverts commit 89a44e3. * Revert "Removed s2s" This reverts commit 929707f. * Revert "Empty s2sConfig case handling added" This reverts commit 2f55e24. * Revert s2s * Removed user sync feature via iframe * Add ajax withCredentials option * Add xhr withCredentials
Type of change
Description of change
Added features to roxot analytics adapter: